From: Jiri Pirko <jiri@resnulli.us>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
sfrench@samba.org, linux-cifs@vger.kernel.org,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink
Date: Thu, 30 Mar 2017 08:17:06 +0200 [thread overview]
Message-ID: <20170330061706.GA2010@nanopsycho> (raw)
In-Reply-To: <20170329173624.GE7942@lunn.ch>
Wed, Mar 29, 2017 at 07:36:24PM CEST, andrew@lunn.ch wrote:
>> Tangential question: we do not currently report to user space what kind
>> of switch tagging protocol is used (DSA, eDSA etc.) I was going to add a
>> sysfs attribute for that under the switch device's directory, but maybe
>> devlink would be more appropriate for that?
>
>We don't report it. What are you thinking you want to do with this
>information?
>
>I suppose it might be possible to teach libpcap/tcpdump about it, so
>it can slide in an additional dissector. EDSA you can detect anyway,
>since it uses a well know Ethertype. tcpdump already supports
>this. But the other tag protocols cannot be detected.
>
>devlink does seem like a good candidate for this, make it part of the
>port type.
I agree this could go out via devlink. Not sure exactly what attr.
Certainly some new.
>
> Andrew
prev parent reply other threads:[~2017-03-30 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 21:45 [PATCH net-next 0/2] break include loop and dsa devlink support Andrew Lunn
[not found] ` <1490737507-7864-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2017-03-28 21:45 ` [PATCH net-next 1/2] net: break include loop netdevice.h, dsa.h, devlink.h Andrew Lunn
[not found] ` <1490737507-7864-2-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2017-03-28 22:04 ` Florian Fainelli
2017-03-29 5:46 ` [PATCH net-next 0/2] break include loop and dsa devlink support David Miller
2017-03-28 21:45 ` [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink Andrew Lunn
2017-03-29 0:33 ` Florian Fainelli
[not found] ` <2fe7ffc9-1bf1-537a-e361-33156a6f5a07-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-29 1:31 ` Andrew Lunn
2017-03-29 17:29 ` Florian Fainelli
[not found] ` <c844a885-cfd3-4358-89dd-c619d3d394e4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-29 17:36 ` Andrew Lunn
2017-03-30 6:17 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330061706.GA2010@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).