From: Salil Mehta <salil.mehta@huawei.com>
To: <davem@davemloft.net>
Cc: <salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<mehta.salil.lnk@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
Kejian Yan <yankejian@huawei.com>
Subject: [PATCH V2 net-next 13/18] net: hns: Clean redundant code from hns_mdio.c file
Date: Fri, 31 Mar 2017 12:20:27 +0100 [thread overview]
Message-ID: <20170331112032.4692-14-salil.mehta@huawei.com> (raw)
In-Reply-To: <20170331112032.4692-1-salil.mehta@huawei.com>
From: Kejian Yan <yankejian@huawei.com>
This patch cleans the redundant code from hns_mdio.c.
Reported-by: Ping Zhang <zhangping5@huawei.com>
Signed-off-by: Kejian Yan <yankejian@huawei.com>
Reviewed-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
drivers/net/ethernet/hisilicon/hns_mdio.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
index 501eb20..fad1c5b 100644
--- a/drivers/net/ethernet/hisilicon/hns_mdio.c
+++ b/drivers/net/ethernet/hisilicon/hns_mdio.c
@@ -23,17 +23,9 @@
#include <linux/phy.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
-#include <linux/spinlock_types.h>
#define MDIO_DRV_NAME "Hi-HNS_MDIO"
#define MDIO_BUS_NAME "Hisilicon MII Bus"
-#define MDIO_DRV_VERSION "1.3.0"
-#define MDIO_COPYRIGHT "Copyright(c) 2015 Huawei Corporation."
-#define MDIO_DRV_STRING MDIO_BUS_NAME
-#define MDIO_DEFAULT_DEVICE_DESCR MDIO_BUS_NAME
-
-#define MDIO_CTL_DEV_ADDR(x) (x & 0x1f)
-#define MDIO_CTL_PORT_ADDR(x) ((x & 0x1f) << 5)
#define MDIO_TIMEOUT 1000000
@@ -64,9 +56,7 @@ struct hns_mdio_device {
#define MDIO_CMD_DEVAD_S 0
#define MDIO_CMD_PRTAD_M 0x1f
#define MDIO_CMD_PRTAD_S 5
-#define MDIO_CMD_OP_M 0x3
#define MDIO_CMD_OP_S 10
-#define MDIO_CMD_ST_M 0x3
#define MDIO_CMD_ST_S 12
#define MDIO_CMD_START_B 14
--
2.7.4
next prev parent reply other threads:[~2017-03-31 11:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 11:20 [PATCH V2 net-next 00/18] net: hns: Misc. HNS Bug Fixes & Code Improvements Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 01/18] net: hns: Fix the implementation of irq affinity function Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 02/18] net: hns: Modify GMAC init TX threshold value Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 03/18] net: hns: Optimize the code for GMAC pad and crc Config Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 04/18] net: hns: Remove redundant memset during buffer release Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 05/18] net: hns: bug fix of ethtool show the speed Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 06/18] net: hns: Optimize hns_nic_common_poll for better performance Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 07/18] net: hns: Fix to adjust buf_size of ring according to mtu Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 08/18] net: hns: Replace netif_tx_lock to ring spin lock Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 09/18] net: hns: Correct HNS RSS key set function Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 10/18] net: hns: Remove the redundant adding and deleting mac function Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 11/18] net: hns: Remove redundant mac_get_id() Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 12/18] net: hns: Remove redundant mac table operations Salil Mehta
2017-03-31 11:20 ` Salil Mehta [this message]
2017-03-31 11:20 ` [PATCH V2 net-next 14/18] net: hns: Optimise the code in hns_mdio_wait_ready() Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 15/18] net: hns: Simplify the exception sequence in hns_ppe_init() Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 16/18] net: hns: Adjust the SBM module buffer threshold Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 17/18] net: hns: Avoid Hip06 chip TX packet line bug Salil Mehta
2017-03-31 11:20 ` [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script & warning fixes Salil Mehta
2017-03-31 15:44 ` Joe Perches
2017-03-31 16:46 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331112032.4692-14-salil.mehta@huawei.com \
--to=salil.mehta@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yankejian@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox