From: Andrew Lunn <andrew@lunn.ch>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Miller <davem@davemloft.net>,
f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] ftgmac100: Mostly rewrite the driver
Date: Fri, 31 Mar 2017 23:56:52 +0200 [thread overview]
Message-ID: <20170331215652.GA27307@lunn.ch> (raw)
In-Reply-To: <1490994867.3177.241.camel@kernel.crashing.org>
> They are incremental, but some of them are trivial and in the end
> it's the end result that matters but yes I could probably split some
> misc stuff, rx path, tx path, and more misc.
Hi Ben
Trivial patches are good. They are easy to review. You should be
aiming for patches which are obviously correct, where ever possible.
Refactoring existing code often has a lot of obviously correct
patches, and a few complex patches which take some effort to review.
Andrew
next prev parent reply other threads:[~2017-03-31 21:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 4:40 [PATCH net] ftgmac100: Mostly rewrite the driver Benjamin Herrenschmidt
2017-03-29 4:57 ` David Miller
2017-03-29 5:03 ` Benjamin Herrenschmidt
2017-03-29 5:10 ` David Miller
2017-03-29 5:18 ` Benjamin Herrenschmidt
2017-03-29 18:08 ` Florian Fainelli
2017-03-29 21:08 ` Benjamin Herrenschmidt
2017-03-30 0:46 ` Benjamin Herrenschmidt
2017-03-30 3:15 ` David Miller
2017-03-31 9:59 ` Benjamin Herrenschmidt
2017-03-31 13:52 ` Andrew Lunn
2017-03-31 21:14 ` Benjamin Herrenschmidt
2017-03-31 21:56 ` Andrew Lunn [this message]
2017-03-31 16:56 ` David Miller
2017-03-29 17:42 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331215652.GA27307@lunn.ch \
--to=andrew@lunn.ch \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).