From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] net: hns: fix boolreturn.cocci warnings Date: Sat, 1 Apr 2017 07:50:55 +0800 Message-ID: <20170331235055.GA28462@lkp-wsm-ep1> References: <201704010733.8LNMN4m7%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, davem@davemloft.net, salil.mehta@huawei.com, yisen.zhuang@huawei.com, mehta.salil.lnk@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, lipeng To: Salil Mehta Return-path: Content-Disposition: inline In-Reply-To: <20170330153106.14344-9-salil.mehta@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1 in function 'hns_enable_serdes_lb' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: lipeng Signed-off-by: Fengguang Wu --- hns_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c @@ -1545,7 +1545,7 @@ static bool hns_enable_serdes_lb(struct /* wait h/w ready */ mdelay(300); - return 0; + return false; } static void hns_disable_serdes_lb(struct net_device *ndev)