* [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h
@ 2017-03-30 16:00 Mark Brown
2017-03-30 22:48 ` Joel Stanley
2017-04-01 19:14 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2017-03-30 16:00 UTC (permalink / raw)
To: David S . Miller, Joel Stanley, Gavin Shan; +Cc: netdev, Mark Brown
This driver uses interfaces from linux/of.h and linux/property.h but
relies on implict inclusion of those headers which means that changes in
other headers could break the build, as happened in -next for arm today.
Add a explicit includes.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 928b0df2b8e0..ade6b3e4ed13 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -28,8 +28,10 @@
#include <linux/io.h>
#include <linux/module.h>
#include <linux/netdevice.h>
+#include <linux/of.h>
#include <linux/phy.h>
#include <linux/platform_device.h>
+#include <linux/property.h>
#include <net/ip.h>
#include <net/ncsi.h>
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h
2017-03-30 16:00 [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h Mark Brown
@ 2017-03-30 22:48 ` Joel Stanley
2017-04-01 19:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Joel Stanley @ 2017-03-30 22:48 UTC (permalink / raw)
To: Mark Brown; +Cc: David S . Miller, Gavin Shan, netdev
On Fri, Mar 31, 2017 at 2:30 AM, Mark Brown <broonie@kernel.org> wrote:
> This driver uses interfaces from linux/of.h and linux/property.h but
> relies on implict inclusion of those headers which means that changes in
> other headers could break the build, as happened in -next for arm today.
> Add a explicit includes.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Joel Stanley <joel@jms.id.au>
Thank you for fixing this Mark.
Cheers,
Joel
> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 928b0df2b8e0..ade6b3e4ed13 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -28,8 +28,10 @@
> #include <linux/io.h>
> #include <linux/module.h>
> #include <linux/netdevice.h>
> +#include <linux/of.h>
> #include <linux/phy.h>
> #include <linux/platform_device.h>
> +#include <linux/property.h>
> #include <net/ip.h>
> #include <net/ncsi.h>
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h
2017-03-30 16:00 [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h Mark Brown
2017-03-30 22:48 ` Joel Stanley
@ 2017-04-01 19:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-04-01 19:14 UTC (permalink / raw)
To: broonie; +Cc: joel, gwshan, netdev
From: Mark Brown <broonie@kernel.org>
Date: Thu, 30 Mar 2017 17:00:12 +0100
> This driver uses interfaces from linux/of.h and linux/property.h but
> relies on implict inclusion of those headers which means that changes in
> other headers could break the build, as happened in -next for arm today.
> Add a explicit includes.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-01 19:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-30 16:00 [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h Mark Brown
2017-03-30 22:48 ` Joel Stanley
2017-04-01 19:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).