From: David Miller <davem@davemloft.net>
To: simon.horman@netronome.com
Cc: dinan.gunawardena@netronome.com, netdev@vger.kernel.org,
oss-drivers@netronome.com, nicolas.iooss_linux@m4x.org
Subject: Re: [PATCH net] flow dissector: correct size of storage for ARP
Date: Mon, 03 Apr 2017 14:47:49 -0700 (PDT) [thread overview]
Message-ID: <20170403.144749.510468372321111720.davem@davemloft.net> (raw)
In-Reply-To: <1491248578-12014-1-git-send-email-simon.horman@netronome.com>
From: Simon Horman <simon.horman@netronome.com>
Date: Mon, 3 Apr 2017 15:42:58 -0400
> The last argument to __skb_header_pointer() should be a buffer large
> enough to store struct arphdr. This can be a pointer to a struct arphdr
> structure. The code was previously using a pointer to a pointer to
> struct arphdr.
>
> By my counting the storage available both before and after is 8 bytes on
> x86_64.
>
> Fixes: 55733350e5e8 ("flow disector: ARP support")
> Reported-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
Applied and queued up for -stable.
> this problem is present in both net, since v4.11-rc1 and net-next.
> However, the code has refactored in net-next. I expect this will result
> in a conflict. Let me know if you would like me to post a version for
> net-next too.
I'll sort out the merge hassles into net-next myself, thanks for
letting me know.
prev parent reply other threads:[~2017-04-03 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 19:42 [PATCH net] flow dissector: correct size of storage for ARP Simon Horman
2017-04-03 21:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403.144749.510468372321111720.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dinan.gunawardena@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).