* [PATCH -next] qed: Add a missing error code
@ 2017-04-03 18:25 Dan Carpenter
2017-04-04 6:13 ` Tayar, Tomer
2017-04-05 13:54 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-04-03 18:25 UTC (permalink / raw)
To: Yuval Mintz, Tomer Tayar
Cc: Ariel Elior, everest-linux-l2, netdev, kernel-janitors
We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The
current code returns success.
Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
index 619eac845028..ff6080df2246 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
@@ -455,8 +455,10 @@ _qed_mcp_cmd_and_union(struct qed_hwfn *p_hwfn,
qed_mcp_reread_offsets(p_hwfn, p_ptt);
seq_num = ++p_hwfn->mcp_info->drv_mb_seq;
p_cmd_elem = qed_mcp_cmd_add_elem(p_hwfn, p_mb_params, seq_num);
- if (!p_cmd_elem)
+ if (!p_cmd_elem) {
+ rc = -ENOMEM;
goto err;
+ }
__qed_mcp_cmd_and_union(p_hwfn, p_ptt, p_mb_params, seq_num);
spin_unlock_bh(&p_hwfn->mcp_info->cmd_lock);
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH -next] qed: Add a missing error code
2017-04-03 18:25 [PATCH -next] qed: Add a missing error code Dan Carpenter
@ 2017-04-04 6:13 ` Tayar, Tomer
2017-04-05 13:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Tayar, Tomer @ 2017-04-04 6:13 UTC (permalink / raw)
To: Dan Carpenter, Mintz, Yuval
Cc: Elior, Ariel, Dept-Eng Everest Linux L2, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
> We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The
> current code returns success.
>
> Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks
Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] qed: Add a missing error code
2017-04-03 18:25 [PATCH -next] qed: Add a missing error code Dan Carpenter
2017-04-04 6:13 ` Tayar, Tomer
@ 2017-04-05 13:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-04-05 13:54 UTC (permalink / raw)
To: dan.carpenter
Cc: Yuval.Mintz, Tomer.Tayar, Ariel.Elior, everest-linux-l2, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 3 Apr 2017 21:25:22 +0300
> We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The
> current code returns success.
>
> Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-05 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-03 18:25 [PATCH -next] qed: Add a missing error code Dan Carpenter
2017-04-04 6:13 ` Tayar, Tomer
2017-04-05 13:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).