From: Felix Manlunas <felix.manlunas@cavium.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Derek Chickles <derek.chickles@caviumnetworks.com>,
Prasad Kanneganti <prasad.kanneganti@cavium.com>,
Satanand Burla <satananda.burla@caviumnetworks.com>,
Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] liquidio: clear the correct memory
Date: Mon, 3 Apr 2017 11:40:20 -0700 [thread overview]
Message-ID: <20170403184020.GA1018@felix-thinkpad.cavium.com> (raw)
In-Reply-To: <20170403181827.GA6505@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 2017-Apr-03 21:18:27 +0300
> There is a cut and paste bug here so we accidentally clear the first
> few bytes of "resp" a second time instead clearing "ctx".
>
> Fixes: 50c0add534d2 ("liquidio: refactor interrupt moderation code")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> index fac02ed2c449..dab10c7e4443 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> @@ -1359,7 +1359,7 @@ static int octnet_get_intrmod_cfg(struct lio *lio,
> memset(resp, 0, sizeof(struct oct_intrmod_resp));
>
> ctx = (struct oct_intrmod_context *)sc->ctxptr;
> - memset(resp, 0, sizeof(struct oct_intrmod_context));
> + memset(ctx, 0, sizeof(struct oct_intrmod_context));
> WRITE_ONCE(ctx->cond, 0);
> ctx->octeon_id = lio_get_device_id(oct_dev);
> init_waitqueue_head(&ctx->wc);
Good catch, Dan. Thanks.
Acked-by: Felix Manlunas <felix.manlunas@cavium.com>
next prev parent reply other threads:[~2017-04-03 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 18:18 [PATCH -next] liquidio: clear the correct memory Dan Carpenter
2017-04-03 18:40 ` Felix Manlunas [this message]
2017-04-05 13:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403184020.GA1018@felix-thinkpad.cavium.com \
--to=felix.manlunas@cavium.com \
--cc=dan.carpenter@oracle.com \
--cc=derek.chickles@caviumnetworks.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prasad.kanneganti@cavium.com \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).