From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: davem@davemloft.net, shuah@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: add a generic testsuite for ethernet device
Date: Tue, 4 Apr 2017 14:22:58 +0200 [thread overview]
Message-ID: <20170404122258.GC31409@lunn.ch> (raw)
In-Reply-To: <20170404075604.GA13800@Red>
On Tue, Apr 04, 2017 at 09:56:04AM +0200, Corentin Labbe wrote:
> On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote:
> > > By ifnum, you mean by the order that "ip link" gives ?
> >
> > I've not checked if it remains in order as interfaces are hot
> > plugged/unplugged. But i guess you are running tests direct after
> > boot, and unplugs/replugs are unlikely?
> >
>
> Yes the ideal run is just after boot, but the test need to succeed in all case.
>
> For handling vlan, I think the best way is to detect the master interface by looking the "@master".
Hi Corentin
In my case, these are DSA interfaces. Documentation/networking/dsa/dsa.txt
> So when testing a vlan interface, the test would just up also the masteri interface.
That will work for DSA.
I know kernelci.org has at least two boards with Ethernet switches
that will have such interfaces. So it is great to test them.
Thanks
Andrew
prev parent reply other threads:[~2017-04-04 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 12:57 [PATCH] selftests: add a generic testsuite for ethernet device Corentin Labbe
2017-03-31 12:57 ` Corentin Labbe
2017-03-31 14:12 ` Andrew Lunn
2017-04-03 13:15 ` Corentin Labbe
2017-04-03 13:27 ` Andrew Lunn
2017-04-04 7:56 ` Corentin Labbe
2017-04-04 12:22 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404122258.GC31409@lunn.ch \
--to=andrew@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).