netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, nicolas.dichtel@6wind.com
Subject: Re: [iproute2 net-next v2 0/3] ip netconf improvements
Date: Tue, 4 Apr 2017 14:39:12 -0700	[thread overview]
Message-ID: <20170404143912.7ecae6ba@xeon-e3> (raw)
In-Reply-To: <431908e0-27b0-730d-0c01-671702f30d71@cumulusnetworks.com>

On Tue, 4 Apr 2017 17:07:31 -0400
David Ahern <dsa@cumulusnetworks.com> wrote:

> On 3/23/17 10:51 PM, David Ahern wrote:
> > Currently, ip netconf only shows data for ipv4 and ipv6 for dumps
> > and just ipv4 for device requests. Improve the user experience by
> > using the new kernel patch to dump all address families that have
> > registered. For example, if mpls_router module is loaded then mpls
> > values are displayed along with ipv4 and ipv6.
> > 
> > If the new feature is not supported (new iproute2 on older kernel)
> > the kernel returns the nlmsg error EOPNOTSUPP which can be trapped
> > and fallback to existing behavior.
> > 
> > v2
> > - fixed index conversion in patch 3 per nicholas' comment
> > 
> > David Ahern (3):
> >   netlink: Add flag to suppress print of nlmsg error
> >   ip netconf: Show all address families by default in dumps
> >   ip netconf: show all families on dev request
> > 
> >  include/libnetlink.h |  1 +
> >  ip/ipnetconf.c       | 36 +++++++++++++++++++++++++-----------
> >  lib/libnetlink.c     |  3 ++-
> >  3 files changed, 28 insertions(+), 12 deletions(-)
> >   
> 
> Hi Stephen: any comments? are you ok with this change?

I was holding off until all the upstream commits went through. Other than
that fine.

  reply	other threads:[~2017-04-04 21:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24  2:51 [iproute2 net-next v2 0/3] ip netconf improvements David Ahern
2017-03-24  2:51 ` [iproute2 net-next v2 1/3] netlink: Add flag to suppress print of nlmsg error David Ahern
2017-03-24  2:51 ` [iproute2 net-next v2 2/3] ip netconf: Show all address families by default in dumps David Ahern
2017-03-24  2:51 ` [iproute2 net-next v2 3/3] ip netconf: show all families on dev request David Ahern
2017-03-24  8:37 ` [iproute2 net-next v2 0/3] ip netconf improvements Nicolas Dichtel
2017-04-04 21:07 ` David Ahern
2017-04-04 21:39   ` Stephen Hemminger [this message]
2017-04-05 12:18     ` David Ahern
2017-04-14 23:02 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170404143912.7ecae6ba@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).