Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator

Pablo Neira Ayuso
2017-04-04T17:56:00Z

On Tue, Apr 04, 2017 at 01:41:11PM -0400, Simon Horman wrote:
> On Wed, Mar 29, 2017 at 03:45:01PM +0530, Arushi Singhal wrote:
> > Replace explicit NULL comparison with ! operator to simplify code.
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> > net/netfilter/ipvs/ip_vs_ctl.c | 8 ++---
> > net/netfilter/ipvs/ip_vs_proto.c | 8 ++---
>
> I count 18 instances of "!= NULL in net/netfilter/ipvs/ip_vs_proto but this
> patch only seems to update 8 of them. I would prefer to fix all or none of
> them.

Agreed.

Please address all instances and resubmit.