From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/1] skbuff: Extend gso_type to unsigned int.
Date: Wed, 05 Apr 2017 06:34:26 -0700 (PDT) [thread overview]
Message-ID: <20170405.063426.330966962521980983.davem@davemloft.net> (raw)
In-Reply-To: <1491207352-27585-2-git-send-email-steffen.klassert@secunet.com>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Mon, 3 Apr 2017 10:15:52 +0200
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 9f78109..8796b93 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -257,7 +257,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask,
>
> /* make sure we initialize shinfo sequentially */
> shinfo = skb_shinfo(skb);
> - memset(shinfo, 0, offsetof(struct skb_shared_info, dataref));
> + memset(shinfo, 0, offsetof(struct skb_shared_info, _unused));
> atomic_set(&shinfo->dataref, 1);
> kmemcheck_annotate_variable(shinfo->destructor_arg);
>
There is another memset() that needs this conversion in __build_skb().
next prev parent reply other threads:[~2017-04-05 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 8:15 [PATCH net-next 0/1] skbuff: Extend gso_type to unsigned int Steffen Klassert
2017-04-03 8:15 ` [PATCH net-next 1/1] " Steffen Klassert
2017-04-05 13:34 ` David Miller [this message]
2017-04-07 13:36 ` David Laight
2017-04-07 14:28 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405.063426.330966962521980983.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).