From: Andrew Lunn <andrew@lunn.ch>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 10/13] ftgmac100: Add a reset task and use it for link changes
Date: Wed, 5 Apr 2017 17:00:46 +0200 [thread overview]
Message-ID: <20170405150046.GH13449@lunn.ch> (raw)
In-Reply-To: <20170405022853.8238-11-benh@kernel.crashing.org>
On Wed, Apr 05, 2017 at 12:28:50PM +1000, Benjamin Herrenschmidt wrote:
> Link speed changes require a full HW reset. This isn't done
> properly at the moment. It will involve delays and thus isn't
> suitable to do from the link poll callback.
>
> So let's create a reset_task that we can queue up when the
> link changes. It will be useful for various cases of error
> handling as well.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-04-05 15:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 2:28 [PATCH v2 00/13] ftgmac100: Rework batch 1 - Link & Interrupts Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 01/13] ftgmac100: Use netdev->irq instead of private copy Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 02/13] ftgmac100: Remove "banner" comments Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 03/13] ftgmac100: Reorder struct fields and comment Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 04/13] ftgmac100: Remove "enabled" flags Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 05/13] ftgmac100: Cleanup speed/duplex tracking and fix duplex config Benjamin Herrenschmidt
2017-04-05 14:58 ` Andrew Lunn
2017-04-05 2:28 ` [PATCH v2 06/13] ftgmac100: Split ring alloc, init and rx buffer alloc Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 07/13] ftgmac100: Move napi_add/del to open/close Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 08/13] ftgmac100: Request the interrupt only after HW is reset Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 09/13] ftgmac100: Move the bulk of inits to a separate function Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 10/13] ftgmac100: Add a reset task and use it for link changes Benjamin Herrenschmidt
2017-04-05 15:00 ` Andrew Lunn [this message]
2017-04-05 2:28 ` [PATCH v2 11/13] ftgmac100: Rework MAC reset and init Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 12/13] ftgmac100: Remove useless tests in interrupt handler Benjamin Herrenschmidt
2017-04-05 2:28 ` [PATCH v2 13/13] ftgmac100: Rework NAPI & interrupts handling Benjamin Herrenschmidt
2017-04-05 4:21 ` [PATCH v2 00/13] ftgmac100: Rework batch 1 - Link & Interrupts Florian Fainelli
2017-04-05 5:53 ` Benjamin Herrenschmidt
2017-04-05 6:02 ` Florian Fainelli
2017-04-05 6:31 ` Benjamin Herrenschmidt
2017-04-06 19:46 ` Florian Fainelli
2017-04-06 21:46 ` Benjamin Herrenschmidt
2017-04-06 19:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405150046.GH13449@lunn.ch \
--to=andrew@lunn.ch \
--cc=benh@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).