netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: hiren panchasara <hiren@strugglingcoder.info>
To: netdev@vger.kernel.org
Subject: tcpprobe display format for snd_nxt and snd_una
Date: Wed, 5 Apr 2017 12:40:09 -0700	[thread overview]
Message-ID: <20170405194009.GH62406@strugglingcoder.info> (raw)

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

(New to linux and first-time poster so please guide me if needed.)
 
Upon using tcpprobe I realized that it prints snd_nxt and snd_una as hex
which makes it harder to read and compare with tcpdump for example.
 
Not sure if that is intentional. If not, a simple patch like this would
print them as decimals.
 
[PATCH] Display snd_nxt and snd_una as decimals for better
 readability.
 
---
 net/ipv4/tcp_probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 
diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
index f6c50af..a8e66c1 100644
--- a/net/ipv4/tcp_probe.c
+++ b/net/ipv4/tcp_probe.c
@@ -191,7 +191,7 @@ static int tcpprobe_sprint(char *tbuf, int n)
                = ktime_to_timespec64(ktime_sub(p->tstamp, tcp_probe.start));
 
        return scnprintf(tbuf, n,
-                       "%lu.%09lu %pISpc %pISpc %d %#x %#x %u %u %u %u %u\n",
+                       "%lu.%09lu %pISpc %pISpc %d %u %u %u %u %u %u %u\n",
                        (unsigned long)ts.tv_sec,
                        (unsigned long)ts.tv_nsec,
                        &p->src, &p->dst, p->length, p->snd_nxt, p->snd_una,

             reply	other threads:[~2017-04-05 19:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 19:40 hiren panchasara [this message]
2017-04-06 21:45 ` tcpprobe display format for snd_nxt and snd_una Stephen Hemminger
2017-04-06 22:16   ` hiren panchasara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170405194009.GH62406@strugglingcoder.info \
    --to=hiren@strugglingcoder.info \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).