* [PATCH] qed: fix missing break in OOO_LB_TC case
@ 2017-04-05 12:35 Colin King
2017-04-05 12:42 ` Mintz, Yuval
2017-04-06 20:24 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-04-05 12:35 UTC (permalink / raw)
To: Yuval Mintz, Ariel Elior, everest-linux-l2, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There seems to be a missing break on the OOO_LB_TC case, pq_id
is being assigned and then re-assigned on the fall through default
case and that seems suspect.
Detected by CoverityScan, CID#1424402 ("Missing break in switch")
Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index 708c601e8ccf..13e65d446ab3 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -1132,6 +1132,7 @@ static int qed_sp_ll2_tx_queue_start(struct qed_hwfn *p_hwfn,
break;
case OOO_LB_TC:
pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OOO);
+ break;
default:
pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OFLD);
break;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] qed: fix missing break in OOO_LB_TC case
2017-04-05 12:35 [PATCH] qed: fix missing break in OOO_LB_TC case Colin King
@ 2017-04-05 12:42 ` Mintz, Yuval
2017-04-06 20:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mintz, Yuval @ 2017-04-05 12:42 UTC (permalink / raw)
To: Colin King, Elior, Ariel, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
> There seems to be a missing break on the OOO_LB_TC case, pq_id is being
> assigned and then re-assigned on the fall through default case and that
> seems suspect.
>
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
>
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks!
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: fix missing break in OOO_LB_TC case
2017-04-05 12:35 [PATCH] qed: fix missing break in OOO_LB_TC case Colin King
2017-04-05 12:42 ` Mintz, Yuval
@ 2017-04-06 20:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-04-06 20:24 UTC (permalink / raw)
To: colin.king
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev,
kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Wed, 5 Apr 2017 13:35:44 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There seems to be a missing break on the OOO_LB_TC case, pq_id
> is being assigned and then re-assigned on the fall through default
> case and that seems suspect.
>
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
>
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-06 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-05 12:35 [PATCH] qed: fix missing break in OOO_LB_TC case Colin King
2017-04-05 12:42 ` Mintz, Yuval
2017-04-06 20:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).