* [PATCH net] l2tp: define SOL_PPPOL2TP in uapi
@ 2017-04-05 14:52 Guillaume Nault
2017-04-06 20:25 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Guillaume Nault @ 2017-04-05 14:52 UTC (permalink / raw)
To: netdev; +Cc: James Chapman
Userspace needs SOL_PPPOL2TP to be defined for using PPPOL2TP_SO_*
socket options.
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
---
include/uapi/linux/if_pppol2tp.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/if_pppol2tp.h b/include/uapi/linux/if_pppol2tp.h
index 6418c4d10241..90ce1abd2c4b 100644
--- a/include/uapi/linux/if_pppol2tp.h
+++ b/include/uapi/linux/if_pppol2tp.h
@@ -73,6 +73,8 @@ struct pppol2tpv3in6_addr {
struct sockaddr_in6 addr; /* IP address and port to send to */
};
+#define SOL_PPPOL2TP 273
+
/* Socket options:
* DEBUG - bitmask of debug message categories
* SENDSEQ - 0 => don't send packets with sequence numbers
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] l2tp: define SOL_PPPOL2TP in uapi
2017-04-05 14:52 [PATCH net] l2tp: define SOL_PPPOL2TP in uapi Guillaume Nault
@ 2017-04-06 20:25 ` David Miller
2017-04-07 7:48 ` Guillaume Nault
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2017-04-06 20:25 UTC (permalink / raw)
To: g.nault; +Cc: netdev, jchapman
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Wed, 5 Apr 2017 16:52:35 +0200
> Userspace needs SOL_PPPOL2TP to be defined for using PPPOL2TP_SO_*
> socket options.
>
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
We really can't do this, there is no precedence for defining the SOL_*
values in the kernel headers, it needs to come from the libc headers just
like the other SOL_* values do for applications.
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] l2tp: define SOL_PPPOL2TP in uapi
2017-04-06 20:25 ` David Miller
@ 2017-04-07 7:48 ` Guillaume Nault
0 siblings, 0 replies; 3+ messages in thread
From: Guillaume Nault @ 2017-04-07 7:48 UTC (permalink / raw)
To: David Miller; +Cc: netdev, jchapman
On Thu, Apr 06, 2017 at 01:25:34PM -0700, David Miller wrote:
> From: Guillaume Nault <g.nault@alphalink.fr>
> Date: Wed, 5 Apr 2017 16:52:35 +0200
>
> > Userspace needs SOL_PPPOL2TP to be defined for using PPPOL2TP_SO_*
> > socket options.
> >
> > Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
>
> We really can't do this, there is no precedence for defining the SOL_*
> values in the kernel headers, it needs to come from the libc headers just
> like the other SOL_* values do for applications.
>
Got it, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-07 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-05 14:52 [PATCH net] l2tp: define SOL_PPPOL2TP in uapi Guillaume Nault
2017-04-06 20:25 ` David Miller
2017-04-07 7:48 ` Guillaume Nault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).