From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: [PATCH RFC v2 0/2] phylib non-autoneg speed setting
Date: Thu, 6 Apr 2017 11:00:33 +0100 [thread overview]
Message-ID: <20170406100033.GA24671@n2100.armlinux.org.uk> (raw)
This set of two patches fixes and cleans up the phylib code associated
with selecting the fixed mode.
phylib currently assumes that all PHYs will support the 10baseT/Half mode
of operation irrespective of the supported bitmask, because of the way
phy_find_valid() and phy_find_setting() operate.
This series resolves that by reimplementing the table lookup, filtering
out all unsupported modes. This results in an unsupported speed setting
always choosing one of the speeds that are supported by the PHY. Full
details are in the patch commit log.
The second patch cleans up the loop in phy_supported_speeds().
drivers/net/phy/phy.c | 119 ++++++++++++++++++++++++++++----------------------
1 file changed, 68 insertions(+), 51 deletions(-)
v1->v2: fixed 0-day build errors
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next reply other threads:[~2017-04-06 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 10:00 Russell King - ARM Linux [this message]
2017-04-06 10:01 ` [PATCH RFC v2 1/2] net: phy: improve phylib correctness for non-autoneg settings Russell King
2017-04-06 10:01 ` [PATCH RFC v2 2/2] net: phy: simplify phy_supported_speeds() Russell King
2017-04-07 20:51 ` [PATCH RFC v2 0/2] phylib non-autoneg speed setting Florian Fainelli
2017-04-13 15:49 ` [PATCH 1/2] net: phy: improve phylib correctness for non-autoneg settings Russell King
2017-04-17 17:25 ` David Miller
2017-04-13 15:49 ` [PATCH 2/2] net: phy: simplify phy_supported_speeds() Russell King
2017-04-17 17:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406100033.GA24671@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).