From: Juergen Borleis <jbe@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, kernel@pengutronix.de,
vivien.didelot@savoirfairelinux.com, davem@davemloft.net
Subject: Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303
Date: Thu, 6 Apr 2017 12:39:22 +0200 [thread overview]
Message-ID: <201704061239.23151.jbe@pengutronix.de> (raw)
In-Reply-To: <20170405181232.GE21965@lunn.ch>
Hi Andrew,
On Wednesday 05 April 2017 20:12:32 Andrew Lunn wrote:
> [...]
> > drivers/net/phy/lan9303-core.c | 924 +++++++++++++++++++++++++++++++++++++++++
> > drivers/net/phy/lan9303.h | 21 +
>
> drivers/net/dsa please.
Done in v2.
> One general comment. I'm assuming parts of this code comes from
> openwrt swconfig. In swconfig, i think they consider switches to be
> part of the PHY layer. In DSA, switches are switches, PHYs are
> PHYs. So the naming in this driver needs to reflect this.
And the LAN9303 is a switch with built-in PHYs :)
Juergen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2017-04-06 10:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 9:20 net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver Juergen Borleis
2017-04-05 9:20 ` [PATCH 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis
2017-04-05 17:10 ` Andrew Lunn
2017-04-06 13:36 ` Juergen Borleis
2017-04-05 9:20 ` [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis
2017-04-05 18:12 ` Andrew Lunn
2017-04-06 10:18 ` Juergen Borleis
2017-04-06 11:59 ` Andrew Lunn
2017-04-06 13:42 ` Juergen Borleis
2017-04-06 10:39 ` Juergen Borleis [this message]
2017-04-05 9:20 ` [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis
2017-04-05 18:21 ` Andrew Lunn
2017-04-06 13:46 ` Juergen Borleis
2017-04-06 13:52 ` Florian Fainelli
2017-04-05 9:20 ` [PATCH 4/4] net: dsa: LAN9303: add MDIO " Juergen Borleis
2017-04-05 19:32 ` Andrew Lunn
2017-04-06 13:53 ` Florian Fainelli
2017-04-06 14:25 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201704061239.23151.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).