From: Jiri Pirko <jiri@resnulli.us>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>, davem@davemloft.net
Subject: Re: [PATCH net] team: call netdev_change_features out of team lock
Date: Thu, 6 Apr 2017 15:24:58 +0200 [thread overview]
Message-ID: <20170406132458.GB2064@nanopsycho> (raw)
In-Reply-To: <dad7cdf64679977bd3ba512180fcfb8ec96d9129.1491457288.git.lucien.xin@gmail.com>
Thu, Apr 06, 2017 at 07:41:28AM CEST, lucien.xin@gmail.com wrote:
>Commit f6988cb63a4e ("team: don't call netdev_change_features under
>team->lock") fixed the issue calling netdev_change_features under
>team->lock for team_compute_features.
>
>But there are still two places where it calls netdev_change_features
>under team->lock, team_port_add and team_port_del. It may cause a
>dead lock when the slave port with LRO enabled is added.
>
>This patch is to fix this dead lock by moving netdev_change_features
>out of team_port_add and team_port_del, and call it after unlocking
>the team lock.
>
>Reported-by: Patrick Talbert <ptalbert@redhat.com>
>Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
prev parent reply other threads:[~2017-04-06 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 5:41 [PATCH net] team: call netdev_change_features out of team lock Xin Long
2017-04-06 13:24 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406132458.GB2064@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox