From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Subject: [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn message Date: Fri, 7 Apr 2017 08:57:23 +0100 Message-ID: <20170407075723.9669-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Santosh Shilimkar , "David S . Miller" , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org Return-path: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Colin Ian King There is a path where ibmr is null and ret has not been initialized and hence a pr_warn message is printing an uninitialized value in ret. Fix this by initializing ret to zero. Detected by CoverityScan, CID#1357946 ("Uninitialized scalar variable") Signed-off-by: Colin Ian King --- net/rds/ib_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index 977f69886c00..4fd637491dd5 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -542,7 +542,7 @@ void *rds_ib_get_mr(struct scatterlist *sg, unsigned long nents, struct rds_ib_device *rds_ibdev; struct rds_ib_mr *ibmr = NULL; struct rds_ib_connection *ic = rs->rs_conn->c_transport_data; - int ret; + int ret = 0; rds_ibdev = rds_ib_get_device(rs->rs_bound_addr); if (!rds_ibdev) { -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html