From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH net-next 1/3] net: dsa: Do not check for NULL dst in tag parsers
Date: Fri, 7 Apr 2017 22:54:27 +0200 [thread overview]
Message-ID: <20170407205427.GC7966@lunn.ch> (raw)
In-Reply-To: <20170407204154.9651-2-f.fainelli@gmail.com>
On Fri, Apr 07, 2017 at 01:41:52PM -0700, Florian Fainelli wrote:
> dsa_switch_rcv() already tests for dst == NULL, so there is no need to duplicate
> the same check within the tag receive functions.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-04-07 20:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 20:41 [PATCH net-next 0/3] net: dsa: Receive path simplifications Florian Fainelli
2017-04-07 20:41 ` [PATCH net-next 1/3] net: dsa: Do not check for NULL dst in tag parsers Florian Fainelli
2017-04-07 20:53 ` Vivien Didelot
2017-04-07 20:54 ` Andrew Lunn [this message]
2017-04-07 20:41 ` [PATCH net-next 2/3] net: dsa: Move skb_unshare() to dsa_switch_rcv() Florian Fainelli
2017-04-07 20:53 ` Vivien Didelot
2017-04-07 20:56 ` Andrew Lunn
2017-04-07 20:41 ` [PATCH net-next 3/3] net: dsa: Factor bottom tag receive functions Florian Fainelli
2017-04-07 20:54 ` Vivien Didelot
2017-04-08 2:33 ` kbuild test robot
2017-04-08 2:56 ` kbuild test robot
2017-04-07 20:53 ` [PATCH net-next 0/3] net: dsa: Receive path simplifications Andrew Lunn
2017-04-07 20:55 ` Florian Fainelli
2017-04-07 20:59 ` Andrew Lunn
2017-04-07 21:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407205427.GC7966@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).