From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: steffen.klassert@secunet.com, netdev@vger.kernel.org,
edumazet@google.com, alexander.duyck@gmail.com
Subject: Re: [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.
Date: Sat, 08 Apr 2017 12:32:34 -0700 (PDT) [thread overview]
Message-ID: <20170408.123234.1062158742988397943.davem@davemloft.net> (raw)
In-Reply-To: <1491677732.10124.94.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 08 Apr 2017 11:55:32 -0700
> On Sat, 2017-04-08 at 20:36 +0200, Steffen Klassert wrote:
>> All available gso_type flags are currently in use, so
>> extend gso_type from 'unsigned short' to 'unsigned int'
>> to be able to add further flags.
>>
>> We reorder the struct skb_shared_info to use
>> two bytes of the four byte hole before dataref.
>> All fields before dataref are cleared, i.e.
>> four bytes more than before the change.
>>
>> The remaining two byte hole is moved to the
>> beginning of the structure, this protects us
>> from immediate overwites on out of bound writes
>> to the sk_buff head.
>
>> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
...
> This looks much better, thanks Steffen.
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2017-04-08 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 18:36 [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int Steffen Klassert
2017-04-08 18:36 ` Steffen Klassert
2017-04-08 18:55 ` Eric Dumazet
2017-04-08 19:32 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-09 16:07 Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408.123234.1062158742988397943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.duyck@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).