From: Jiri Benc <jbenc@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
pablo@netfilter.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC] netlink: send exterr cookie on success
Date: Sat, 8 Apr 2017 11:28:43 -0400 [thread overview]
Message-ID: <20170408112844.3aa4d448@griffin> (raw)
In-Reply-To: <20170407194402.4181-1-johannes@sipsolutions.net>
On Fri, 7 Apr 2017 21:44:02 +0200, Johannes Berg wrote:
> @@ -67,6 +67,8 @@ struct netlink_ext_err {
> u32 ext_code;
> u32 msg_offset;
> u16 attr;
> + const u8 *cookie;
> + u8 cookie_len;
> };
Perhaps the structure should be named just "netlink_ext" or so? It
seems it'll pick up some non-error related usage, such as the cookies
here or, in the future, flags indicating how the message should be
parsed.
Thanks,
Jiri
next prev parent reply other threads:[~2017-04-08 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 19:44 [RFC] netlink: send exterr cookie on success Johannes Berg
2017-04-08 15:28 ` Jiri Benc [this message]
2017-04-08 15:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408112844.3aa4d448@griffin \
--to=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).