From: Ido Schimmel <idosch@idosch.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: cera@cera.cz, mlxsw@mellanox.com, nikolay@cumulusnetworks.com,
netdev@vger.kernel.org, peter@svinota.eu,
bridge@lists.linux-foundation.org, idosch@mellanox.com,
davem@davemloft.net
Subject: Re: [PATCH net v2 1/2] bridge: implement missing ndo_uninit()
Date: Sat, 8 Apr 2017 16:49:38 +0300 [thread overview]
Message-ID: <20170408134938.GA28955@splinter> (raw)
In-Reply-To: <20170408093042.20b08c5d@plumbers-lap.home.lan>
On Sat, Apr 08, 2017 at 09:30:42AM -0400, Stephen Hemminger wrote:
> On Sat, 8 Apr 2017 14:41:58 +0300
> <idosch@mellanox.com> wrote:
>
> > static void br_dev_free(struct net_device *dev)
> > {
> > - struct net_bridge *br = netdev_priv(dev);
> > -
> > - free_percpu(br->stats);
> > free_netdev(dev);
> > }
> >
>
> Since the only thing left is free_netdev, you can now just set dev->destructor
> to be free_netdev.
Fine.
Beside stylistic issues, I would appreciate comments on how this should
be handled. Are we reverting the patch in the Fixes line or applying
this patchset?
I prefer the first option. Then after net is merged into net-next I can
re-post this patchset with the requested changes.
next prev parent reply other threads:[~2017-04-08 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 11:41 [PATCH net v2 0/2] bridge: Fix kernel oops during bridge creation idosch
2017-04-08 11:41 ` [PATCH net v2 1/2] bridge: implement missing ndo_uninit() idosch
2017-04-08 13:30 ` Stephen Hemminger
2017-04-08 13:49 ` Ido Schimmel [this message]
2017-04-08 14:05 ` Nikolay Aleksandrov
2017-04-08 14:14 ` Stephen Hemminger
2017-04-08 14:14 ` Ivan Vecera
2017-04-08 14:23 ` Ivan Vecera
2017-04-08 11:41 ` [PATCH net v2 2/2] bridge: netlink: register netdevice before executing changelink idosch
2017-04-08 13:32 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408134938.GA28955@splinter \
--to=idosch@idosch.org \
--cc=bridge@lists.linux-foundation.org \
--cc=cera@cera.cz \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=peter@svinota.eu \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).