From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, xdp-newbies@vger.kernel.org
Subject: Re: [PATCH net-next RFC] Generic XDP
Date: Sun, 9 Apr 2017 15:46:55 +0200 [thread overview]
Message-ID: <20170409134655.GA2133@lunn.ch> (raw)
In-Reply-To: <20170408.200721.109499285021338999.davem@davemloft.net>
> + switch (act) {
> + case XDP_PASS:
> + case XDP_TX:
> + break;
> +
> + default:
> + bpf_warn_invalid_xdp_action(act);
Hi David
You might want to put a /* fall through */ comment here, just to
prevent newbies from submitting patches moving the default clause to
the end.
Andrew
> + case XDP_ABORTED:
> + trace_xdp_exception(skb->dev, xdp_prog, act);
> + case XDP_DROP:
> + do_drop:
> + kfree_skb(skb);
> + break;
> + }
> +
> + return act;
> +}
next prev parent reply other threads:[~2017-04-09 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 3:07 [PATCH net-next RFC] Generic XDP David Miller
2017-04-09 5:17 ` Andy Gospodarek
2017-04-09 19:25 ` David Miller
2017-04-09 6:25 ` Johannes Berg
2017-04-09 7:04 ` Johannes Berg
2017-04-09 19:47 ` David Miller
2017-04-09 13:46 ` Andrew Lunn [this message]
2017-04-09 19:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170409134655.GA2133@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).