From: David Miller <davem@davemloft.net>
To: andy@greyhouse.net
Cc: netdev@vger.kernel.org, xdp-newbies@vger.kernel.org
Subject: Re: [PATCH v2 net-next RFC] Generic XDP
Date: Mon, 10 Apr 2017 15:34:56 -0400 (EDT) [thread overview]
Message-ID: <20170410.153456.2120460675454633725.davem@davemloft.net> (raw)
In-Reply-To: <20170410183935.GB4730@C02RW35GFVH8.dhcp.broadcom.net>
From: Andy Gospodarek <andy@greyhouse.net>
Date: Mon, 10 Apr 2017 14:39:35 -0400
> I also noted that...
>
> xdp1 not parsing the protocol correctly. All traffic was showing up as
> protocol '0' instead of '17' in the output.
>
> xdp2 was not actually sending the frames back out when using this patch.
>
> I'll take a look in a bit and see if I can track these two issues down.
Read Alexei's earlier posting, he spotted the bugs you are seeing
here.
Basically, the MAC header is pulled already so we have to push it back
before we run XDP over it. We also have to be similarly careful with
the MAC header for XDP_TX cases.
next prev parent reply other threads:[~2017-04-10 19:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 20:35 [PATCH v2 net-next RFC] Generic XDP David Miller
2017-04-10 2:18 ` Alexei Starovoitov
2017-04-10 16:57 ` Willem de Bruijn
2017-04-10 19:33 ` David Miller
2017-04-10 19:50 ` Daniel Borkmann
2017-04-10 18:39 ` Andy Gospodarek
2017-04-10 19:28 ` David Miller
2017-04-10 21:30 ` Andy Gospodarek
2017-04-10 21:47 ` Michael Chan
2017-04-11 0:56 ` David Miller
2017-04-10 19:34 ` David Miller [this message]
2017-04-10 21:33 ` Andy Gospodarek
2017-04-10 20:12 ` Daniel Borkmann
2017-04-10 21:41 ` Andy Gospodarek
2017-04-11 16:05 ` Eric Dumazet
2017-04-11 16:12 ` Eric Dumazet
2017-04-10 19:28 ` Stephen Hemminger
2017-04-10 21:08 ` Daniel Borkmann
2017-04-11 16:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410.153456.2120460675454633725.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=netdev@vger.kernel.org \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).