From: Andrew Lunn <andrew@lunn.ch>
To: Martin Wetterwald <martin@wetterwald.eu>
Cc: davem@davemloft.org,
Steve Glendinning <steve.glendinning@shawell.net>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] smsc95xx: Add comments to the registers definition
Date: Mon, 10 Apr 2017 15:52:51 +0200 [thread overview]
Message-ID: <20170410135251.GC19820@lunn.ch> (raw)
In-Reply-To: <20170410084521.w2kdjpdquvrg72mr@SMX-2>
Hi Martin
> @@ -2032,7 +2032,7 @@ static struct sk_buff *smsc95xx_tx_fixup(struct usbnet *dev,
> skb_push(skb, 4);
> tx_cmd_b = (u32)(skb->len - 4);
> if (csum)
> - tx_cmd_b |= TX_CMD_B_CSUM_ENABLE;
> + tx_cmd_b |= TX_CMD_B_CSUM_EN;
This changed seems a step backwards, ENABLE is much more readable than EN.
>
> -#define TX_CMD_B_CSUM_ENABLE (0x00004000)
> -#define TX_CMD_B_ADD_CRC_DISABLE_ (0x00002000)
> -#define TX_CMD_B_DISABLE_PADDING_ (0x00001000)
> -#define TX_CMD_B_PKT_BYTE_LENGTH_ (0x000007FF)
> +#define TX_CMD_B_CSUM_EN (0x00004000) /* TX Checksum Enable */
And there is space for ABLE here.
Andrew
next prev parent reply other threads:[~2017-04-10 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 8:45 [PATCH] smsc95xx: Add comments to the registers definition Martin Wetterwald
2017-04-10 13:52 ` Andrew Lunn [this message]
2017-04-12 2:18 ` David Miller
2017-04-12 9:24 ` [PATCH v3] " Martin Wetterwald
2017-04-12 9:32 ` Steve Glendinning
2017-04-12 11:57 ` Andrew Lunn
2017-04-12 14:25 ` Woojung.Huh
2017-04-12 16:01 ` martin
2017-04-12 22:10 ` Woojung.Huh-UWL1GkI3JZL3oGB3hsPCZA
2017-04-13 8:10 ` martin
2017-04-12 14:46 ` David Miller
2017-04-13 8:08 ` [PATCH v4] " Martin Wetterwald
2017-04-13 22:23 ` Woojung.Huh
2017-04-17 17:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410135251.GC19820@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin@wetterwald.eu \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).