From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Marcin Wojtas <mw@semihalf.com>,
Stefan Chulski <stefanc@marvell.com>,
Andrew Lunn <andrew@lunn.ch>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: [PATCH 0/6] mvmdio updates
Date: Mon, 10 Apr 2017 16:27:28 +0100 [thread overview]
Message-ID: <20170410152728.GT17774@n2100.armlinux.org.uk> (raw)
This series of patches update mvmdio for Armada 8k CP110. A number of
issues were found:
1. The driver fails to disable an interrupt when something goes wrong
in the probe function.
2. The interrupt is specified in DT to be optional, but the driver
unconditionally writes to the interrupt mask register, which may
not exist.
3. The DT binding specifies
"reg: address and length of the SMI register"
however, when supporting the interrupt, the size must cover the
interrupt register as well. Update the binding documentation
with this information that was previously omitted.
4. If the register size is too small, have the driver print an error
and disable use of the interrupt.
5. Armada 8k needs three clocks for the MDIO interface, otherwise the
SoC hangs (since it is part of one of the ethernet interfaces.)
GOP clock, MG core clock and MG clock are needed on 8k. Augment the
binding and driver to allow three clocks to be specified.
.../devicetree/bindings/net/marvell-orion-mdio.txt | 19 ++++++++--
drivers/net/ethernet/marvell/mvmdio.c | 44 +++++++++++++++++-----
2 files changed, 50 insertions(+), 13 deletions(-)
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next reply other threads:[~2017-04-10 15:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 15:27 Russell King - ARM Linux [this message]
2017-04-10 15:28 ` [PATCH 1/6] net: mvmdio: disable interrupts in driver failure path Russell King
2017-04-10 19:24 ` Andrew Lunn
2017-04-10 15:28 ` [PATCH 2/6] net: mvmdio: fix interrupt disable in remove path Russell King
2017-04-10 19:25 ` Andrew Lunn
2017-04-10 15:28 ` [PATCH 3/6] dt-bindings: correct marvell orion MDIO binding document Russell King
[not found] ` <E1cxbEl-0006gK-1Q-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
2017-04-10 19:28 ` Andrew Lunn
2017-04-10 15:28 ` [PATCH 4/6] net: mvmdio: disable interrupt if resource size is too small Russell King
2017-04-10 19:29 ` Andrew Lunn
2017-04-10 15:28 ` [PATCH 5/6] dt-bindings: allow up to three clocks for orion-mdio Russell King
[not found] ` <E1cxbEv-0006gY-PO-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
2017-04-10 19:57 ` Andrew Lunn
2017-04-10 15:28 ` [PATCH 6/6] net: mvmdio: allow up to three clocks to be specified " Russell King
2017-04-10 19:31 ` Andrew Lunn
[not found] ` <20170410152728.GT17774-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-04-10 19:57 ` [PATCH 0/6] mvmdio updates Marcin Wojtas
2017-04-13 14:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410152728.GT17774@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).