From: Stephen Hemminger <stephen@networkplumber.org>
To: idosch@idosch.org
Cc: netdev@vger.kernel.org, davem@davemloft.net,
bridge@lists.linux-foundation.org, mlxsw@mellanox.com,
peter@svinota.eu, nikolay@cumulusnetworks.com,
Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net v3 0/2] bridge: Fix kernel oops during bridge creation
Date: Mon, 10 Apr 2017 16:06:01 -0400 [thread overview]
Message-ID: <20170410160601.67120d94@plumbers-lap.home.lan> (raw)
In-Reply-To: <20170410115928.9344-1-idosch@idosch.org>
On Mon, 10 Apr 2017 14:59:26 +0300
idosch@idosch.org wrote:
> From: Ido Schimmel <idosch@mellanox.com>
>
> First patch adds a missing ndo_uninit() in the bridge driver, which is a
> prerequisite for the second patch that actually fixes the oops.
>
> Please consider both patches for 4.4.y, 4.9.y and 4.10.y
>
> Ido Schimmel (2):
> bridge: implement missing ndo_uninit()
> bridge: netlink: register netdevice before executing changelink
>
> net/bridge/br_device.c | 20 +++++++++++---------
> net/bridge/br_if.c | 1 -
> net/bridge/br_multicast.c | 7 +++++--
> net/bridge/br_netlink.c | 7 +++++--
> net/bridge/br_private.h | 5 +++++
> 5 files changed, 26 insertions(+), 14 deletions(-)
>
Looks good, thanks for following through on this.
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2017-04-10 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 11:59 [PATCH net v3 0/2] bridge: Fix kernel oops during bridge creation idosch
2017-04-10 11:59 ` [PATCH net v3 1/2] bridge: implement missing ndo_uninit() idosch
2017-04-10 11:59 ` [PATCH net v3 2/2] bridge: netlink: register netdevice before executing changelink idosch
2017-04-10 20:06 ` Stephen Hemminger [this message]
2017-04-12 2:23 ` [PATCH net v3 0/2] bridge: Fix kernel oops during bridge creation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410160601.67120d94@plumbers-lap.home.lan \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=peter@svinota.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).