From: David Miller <davem@davemloft.net>
To: Joao.Pinto@synopsys.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: add drop transmit status feature
Date: Tue, 11 Apr 2017 14:53:05 -0400 (EDT) [thread overview]
Message-ID: <20170411.145305.907770601077151355.davem@davemloft.net> (raw)
In-Reply-To: <738665b880f7c661c4108d34a9d8fc43ef2f9fa4.1491921785.git.jpinto@synopsys.com>
From: Joao Pinto <Joao.Pinto@synopsys.com>
Date: Tue, 11 Apr 2017 15:44:10 +0100
> +static void dwmac4_enable_tx_drop(struct mac_device_info *hw)
> +{
> + void __iomem *ioaddr = hw->pcsr;
> + u32 value = readl(ioaddr + MTL_OPERATION_MODE);
> +
> + value &= ~MTL_OPERATION_DTXSTS;
> + value |= MTL_OPERATION_DTXSTS;
I think the mask is unnecessary, just simply set the bit.
prev parent reply other threads:[~2017-04-11 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 14:44 [PATCH] net: stmmac: add drop transmit status feature Joao Pinto
2017-04-11 15:04 ` Andrew Lunn
2017-04-11 15:10 ` Joao Pinto
2017-04-11 18:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411.145305.907770601077151355.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joao.Pinto@synopsys.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).