From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org, ast@fb.com, daniel@iogearbox.net,
fengc@google.com, lorenzo@google.com, willemb@google.com
Subject: Re: [PATCH net-next v2] bpf: pass sk to helper functions
Date: Tue, 11 Apr 2017 14:54:46 -0400 (EDT) [thread overview]
Message-ID: <20170411.145446.1300958521081310466.davem@davemloft.net> (raw)
In-Reply-To: <20170411180808.109636-1-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Tue, 11 Apr 2017 14:08:08 -0400
> From: Willem de Bruijn <willemb@google.com>
>
> BPF helper functions access socket fields through skb->sk. This is not
> set in ingress cgroup and socket filters. The association is only made
> in skb_set_owner_r once the filter has accepted the packet. Sk is
> available as socket lookup has taken place.
>
> Temporarily set skb->sk to sk in these cases.
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied, thank you.
prev parent reply other threads:[~2017-04-11 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 18:08 [PATCH net-next v2] bpf: pass sk to helper functions Willem de Bruijn
2017-04-11 18:14 ` Alexei Starovoitov
2017-04-11 18:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411.145446.1300958521081310466.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=fengc@google.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).