netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* WARN_ON running XDP on virtio net device
@ 2017-04-10 21:21 David Ahern
  2017-04-10 21:24 ` Michael S. Tsirkin
  2017-04-10 21:37 ` Michael S. Tsirkin
  0 siblings, 2 replies; 4+ messages in thread
From: David Ahern @ 2017-04-10 21:21 UTC (permalink / raw)
  To: jasowang, Michael S. Tsirkin, netdev@vger.kernel.org

I'm hitting a WARN_ON running XDP with virtio net:

[  177.185570] ------------[ cut here ]------------
[  177.187250] WARNING: CPU: 0 PID: 880 at
/home/dsa/kernel.git/drivers/pci/msi.c:1251 pci_irq_vector+0x92/0x123
[  177.190932] Modules linked in: 8021q garp mrp stp llc vrf
[  177.193473] CPU: 0 PID: 880 Comm: xdp1 Not tainted 4.11.0-rc5+ #305
[  177.195640] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 1.7.5-20140531_083030-gandalf 04/01/2014
[  177.199190] Call Trace:
[  177.200072]  dump_stack+0x81/0xb6
[  177.201018]  __warn+0x107/0x122
[  177.201899]  warn_slowpath_null+0x1d/0x1f
[  177.203014]  pci_irq_vector+0x92/0x123
[  177.204082]  vp_synchronize_vectors+0x6f/0x81
[  177.205293]  vp_reset+0x50/0x55
[  177.206174]  virtnet_xdp+0x346/0x6dd
[  177.207188]  dev_change_xdp_fd+0x12a/0x151
[  177.208256]  do_setlink+0x1288/0x130a

Seems to be something introduced in the past month or so. 2 attempts to
bisect it pointed to this commit:

commit 54d7989f476ca57fc3c5cc71524c480ccb74c481
Merge: 0f221a3102bb c4baad50297d
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu Mar 2 13:53:13 2017 -0800

    Merge tag 'for_linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost

    Pull vhost updates from Michael Tsirkin:
     "virtio, vhost: optimizations, fixes

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: WARN_ON running XDP on virtio net device
  2017-04-10 21:21 WARN_ON running XDP on virtio net device David Ahern
@ 2017-04-10 21:24 ` Michael S. Tsirkin
  2017-04-10 21:37 ` Michael S. Tsirkin
  1 sibling, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2017-04-10 21:24 UTC (permalink / raw)
  To: David Ahern; +Cc: jasowang, netdev@vger.kernel.org

On Mon, Apr 10, 2017 at 03:21:53PM -0600, David Ahern wrote:
> I'm hitting a WARN_ON running XDP with virtio net:
> 
> [  177.185570] ------------[ cut here ]------------
> [  177.187250] WARNING: CPU: 0 PID: 880 at
> /home/dsa/kernel.git/drivers/pci/msi.c:1251 pci_irq_vector+0x92/0x123
> [  177.190932] Modules linked in: 8021q garp mrp stp llc vrf
> [  177.193473] CPU: 0 PID: 880 Comm: xdp1 Not tainted 4.11.0-rc5+ #305
> [  177.195640] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS 1.7.5-20140531_083030-gandalf 04/01/2014
> [  177.199190] Call Trace:
> [  177.200072]  dump_stack+0x81/0xb6
> [  177.201018]  __warn+0x107/0x122
> [  177.201899]  warn_slowpath_null+0x1d/0x1f
> [  177.203014]  pci_irq_vector+0x92/0x123
> [  177.204082]  vp_synchronize_vectors+0x6f/0x81
> [  177.205293]  vp_reset+0x50/0x55
> [  177.206174]  virtnet_xdp+0x346/0x6dd
> [  177.207188]  dev_change_xdp_fd+0x12a/0x151
> [  177.208256]  do_setlink+0x1288/0x130a
> 
> Seems to be something introduced in the past month or so. 2 attempts to
> bisect it pointed to this commit:
> 
> commit 54d7989f476ca57fc3c5cc71524c480ccb74c481
> Merge: 0f221a3102bb c4baad50297d
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Thu Mar 2 13:53:13 2017 -0800
> 
>     Merge tag 'for_linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost
> 
>     Pull vhost updates from Michael Tsirkin:
>      "virtio, vhost: optimizations, fixes

I'm preparing a pull request reverting some changes we made
there. I'd be thankful if you can check whether

git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost linux-next

help with this.


Thanks

-- 
MST

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: WARN_ON running XDP on virtio net device
  2017-04-10 21:21 WARN_ON running XDP on virtio net device David Ahern
  2017-04-10 21:24 ` Michael S. Tsirkin
@ 2017-04-10 21:37 ` Michael S. Tsirkin
  2017-04-10 22:33   ` David Ahern
  1 sibling, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2017-04-10 21:37 UTC (permalink / raw)
  To: David Ahern; +Cc: jasowang, netdev@vger.kernel.org

On Mon, Apr 10, 2017 at 03:21:53PM -0600, David Ahern wrote:
> I'm hitting a WARN_ON running XDP with virtio net:

I just sent a pull request. Would appreciate reports on whether
it helps.

> [  177.185570] ------------[ cut here ]------------
> [  177.187250] WARNING: CPU: 0 PID: 880 at
> /home/dsa/kernel.git/drivers/pci/msi.c:1251 pci_irq_vector+0x92/0x123
> [  177.190932] Modules linked in: 8021q garp mrp stp llc vrf
> [  177.193473] CPU: 0 PID: 880 Comm: xdp1 Not tainted 4.11.0-rc5+ #305
> [  177.195640] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS 1.7.5-20140531_083030-gandalf 04/01/2014
> [  177.199190] Call Trace:
> [  177.200072]  dump_stack+0x81/0xb6
> [  177.201018]  __warn+0x107/0x122
> [  177.201899]  warn_slowpath_null+0x1d/0x1f
> [  177.203014]  pci_irq_vector+0x92/0x123
> [  177.204082]  vp_synchronize_vectors+0x6f/0x81
> [  177.205293]  vp_reset+0x50/0x55
> [  177.206174]  virtnet_xdp+0x346/0x6dd
> [  177.207188]  dev_change_xdp_fd+0x12a/0x151
> [  177.208256]  do_setlink+0x1288/0x130a
> 
> Seems to be something introduced in the past month or so. 2 attempts to
> bisect it pointed to this commit:
> 
> commit 54d7989f476ca57fc3c5cc71524c480ccb74c481
> Merge: 0f221a3102bb c4baad50297d
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Thu Mar 2 13:53:13 2017 -0800
> 
>     Merge tag 'for_linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost
> 
>     Pull vhost updates from Michael Tsirkin:
>      "virtio, vhost: optimizations, fixes

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: WARN_ON running XDP on virtio net device
  2017-04-10 21:37 ` Michael S. Tsirkin
@ 2017-04-10 22:33   ` David Ahern
  0 siblings, 0 replies; 4+ messages in thread
From: David Ahern @ 2017-04-10 22:33 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: jasowang, netdev@vger.kernel.org

On 4/10/17 3:37 PM, Michael S. Tsirkin wrote:
> On Mon, Apr 10, 2017 at 03:21:53PM -0600, David Ahern wrote:
>> I'm hitting a WARN_ON running XDP with virtio net:
> I just sent a pull request. Would appreciate reports on whether
> it helps.
> 

it does.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-04-10 22:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-10 21:21 WARN_ON running XDP on virtio net device David Ahern
2017-04-10 21:24 ` Michael S. Tsirkin
2017-04-10 21:37 ` Michael S. Tsirkin
2017-04-10 22:33   ` David Ahern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).