From: Jakub Kicinski <kubakici@wp.pl>
To: Edward Cree <ecree@solarflare.com>
Cc: Tom Herbert <tom@herbertland.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>
Subject: Re: RFC: Checksum offload and XDP
Date: Tue, 11 Apr 2017 11:43:24 -0700 [thread overview]
Message-ID: <20170411114324.3fd8d9ba@cakuba.lan> (raw)
In-Reply-To: <21cd2caf-56a8-a330-1260-a55ddf07d854@solarflare.com>
On Tue, 11 Apr 2017 18:13:37 +0100, Edward Cree wrote:
> > Note that this only applies to
> > checksum_complete, if we were to allow XDP program to return
> > checksum_unnecessary for instance then it's more a leap of faith that
> > things are always correct.
> Speaking of checksum_unnecessary, it might still be useful for the
> verifier to tell us whether the program contains any writes, since if
> so any drivers using checksum_unnecessary will have to clear it when
> calling XDP or else do conversion to checksum_complete beforehand.
If we exposed csum_complete as a value in xdp buffer, we could make the
unnecessary -> complete conversion dependent on accesses to that field
rather than writes and header adjustments. If program doesn't read or
write the csum it doesn't care about the csum.
And make invalidation of unnecessary dependent on writes and header
adjustments.
prev parent reply other threads:[~2017-04-11 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 18:26 RFC: Checksum offload and XDP Tom Herbert
2017-04-11 15:55 ` Edward Cree
2017-04-11 16:43 ` Daniel Borkmann
2017-04-11 18:34 ` Jakub Kicinski
2017-04-11 19:00 ` David Miller
2017-04-11 16:46 ` Tom Herbert
2017-04-11 17:13 ` Edward Cree
2017-04-11 17:26 ` Tom Herbert
2017-04-11 18:43 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411114324.3fd8d9ba@cakuba.lan \
--to=kubakici@wp.pl \
--cc=ast@kernel.org \
--cc=ecree@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).