From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put() Date: Wed, 12 Apr 2017 10:19:48 -0400 (EDT) Message-ID: <20170412.101948.1029703170663355691.davem@davemloft.net> References: <20170410131106.27683-1-weiyj.lk@gmail.com> <20170411.230328.1122763321161603727.davem@davemloft.net> <6AADFAC011213A4C87B956458587ADB47B0128@SZXEMI508-MBX.china.huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jiri@mellanox.com, arkadis@mellanox.com, netdev@vger.kernel.org To: weiyongjun1@huawei.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45588 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753881AbdDLOTt (ORCPT ); Wed, 12 Apr 2017 10:19:49 -0400 In-Reply-To: <6AADFAC011213A4C87B956458587ADB47B0128@SZXEMI508-MBX.china.huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: From: "weiyongjun (A)" Date: Wed, 12 Apr 2017 03:30:25 +0000 > Hi David, > >> -----Original Message----- >> From: David Miller [mailto:davem@davemloft.net] >> Sent: Wednesday, April 12, 2017 11:03 AM >> To: weiyj.lk@gmail.com >> Cc: jiri@mellanox.com; arkadis@mellanox.com; weiyongjun (A) >> ; netdev@vger.kernel.org >> Subject: Re: [PATCH net-next] devlink: fix return value check in >> devlink_dpipe_header_put() >> >> From: Wei Yongjun >> Date: Mon, 10 Apr 2017 13:11:06 +0000 >> >> > From: Wei Yongjun >> > >> > Fix the retrn value check which testing the wrong variable >> > in devlink_dpipe_header_put(). >> > >> > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") >> > Signed-off-by: Wei Yongjun >> >> This doesn't apply cleanly to net-next, please respin and also fix >> the typo in your commit message as pointed out by Jiri. > > You have applied the v2 version of this patch some hours ago. Aha, my bad. Thanks!