From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions Date: Wed, 12 Apr 2017 15:24:50 +0200 Message-ID: <20170412132450.GD1952@nanopsycho> References: <20170412123408.22012-1-johannes@sipsolutions.net> <20170412123408.22012-5-johannes@sipsolutions.net> <20170412131708.GC1952@nanopsycho> <1492003236.2855.5.camel@sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, pablo@netfilter.org, Jamal Hadi Salim , Jiri Benc , David Ahern To: Johannes Berg Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:35882 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbdDLNYx (ORCPT ); Wed, 12 Apr 2017 09:24:53 -0400 Received: by mail-wm0-f68.google.com with SMTP id q125so6393377wmd.3 for ; Wed, 12 Apr 2017 06:24:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1492003236.2855.5.camel@sipsolutions.net> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Apr 12, 2017 at 03:20:36PM CEST, johannes@sipsolutions.net wrote: >On Wed, 2017-04-12 at 15:17 +0200, Jiri Pirko wrote: >> Wed, Apr 12, 2017 at 02:34:07PM CEST, johannes@sipsolutions.net >> wrote: >> > From: Johannes Berg >> > >> > Pass the new extended ACK reporting struct to all of the >> >> Johannes, I wonder, is there a reason you ignore my comments about >> narrow descriptions? Why don't you use the whole line? > >I don't think it makes sense. Text is easier to read if it's narrower, >80 columns was never desired (only 72), and frankly, I think discussing >the commit or comment line length is pretty useless. You are the only one not using 72 chars for some undefined reasons. But in patch 3/5 you actually do. Sorry but that is just weird. All I'm saying.