From: David Miller <davem@davemloft.net>
To: gfree.wind@foxmail.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, netdev@vger.kernel.org,
fgao@ikuai8.com
Subject: Re: [PATCH net-next v3 1/1] net: ipv4: Refine the ipv4_default_advmss
Date: Thu, 13 Apr 2017 13:20:20 -0400 (EDT) [thread overview]
Message-ID: <20170413.132020.858368201657633084.davem@davemloft.net> (raw)
In-Reply-To: <1491971643-117736-1-git-send-email-gfree.wind@foxmail.com>
From: gfree.wind@foxmail.com
Date: Wed, 12 Apr 2017 12:34:03 +0800
> From: Gao Feng <fgao@ikuai8.com>
>
> 1. Don't get the metric RTAX_ADVMSS of dst.
> There are two reasons.
> 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss
> before invoke default_advmss.
> 2) The ipv4_default_advmss is used to get the default mss, it should
> not try to get the metric like ip6_default_advmss.
>
> 2. Use sizeof(tcphdr)+sizeof(iphdr) instead of literal 40.
>
> 3. Define one new macro IPV4_MAX_PMTU instead of 65535 according to
> RFC 2675, section 5.1.
>
> Signed-off-by: Gao Feng <fgao@ikuai8.com>
> ---
> v3: Simplify the codes again, per Joe
> v2: Use min instead of unnecessary min_t, per Joe
> v1: initial version
Applied, thanks.
prev parent reply other threads:[~2017-04-13 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 4:34 [PATCH net-next v3 1/1] net: ipv4: Refine the ipv4_default_advmss gfree.wind
2017-04-13 17:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413.132020.858368201657633084.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).