* [PATCH next] bonding: handle link transition from FAIL to UP correctly
@ 2017-04-12 5:36 Mahesh Bandewar
2017-04-13 17:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mahesh Bandewar @ 2017-04-12 5:36 UTC (permalink / raw)
To: Jay Vosburgh, Andy Gospodarek, Veaceslav Falico,
Nikolay Aleksandrov, David Miller, Eric Dumazet
Cc: netdev, Mahesh Bandewar, Mahesh Bandewar
From: Mahesh Bandewar <maheshb@google.com>
When link transitions from LINK_FAIL to LINK_UP, the commit phase is
not called. This leads to an erroneous state causing slave-link state to
get stuck in "going down" state while its speed and duplex are perfectly
fine. This issue is a side-effect of splitting link-set into propose and
commit phases introduced by de77ecd4ef02 ("bonding: improve link-status
update in mii-monitoring")
This patch fixes these issues by calling commit phase whenever link
state change is proposed.
Fixes: de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
drivers/net/bonding/bond_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index aba7352906a5..01e4a69af421 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2064,6 +2064,7 @@ static int bond_miimon_inspect(struct bonding *bond)
(bond->params.downdelay - slave->delay) *
bond->params.miimon,
slave->dev->name);
+ commit++;
continue;
}
@@ -2098,7 +2099,7 @@ static int bond_miimon_inspect(struct bonding *bond)
(bond->params.updelay - slave->delay) *
bond->params.miimon,
slave->dev->name);
-
+ commit++;
continue;
}
--
2.12.2.715.g7642488e1d-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] bonding: handle link transition from FAIL to UP correctly
2017-04-12 5:36 [PATCH next] bonding: handle link transition from FAIL to UP correctly Mahesh Bandewar
@ 2017-04-13 17:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-04-13 17:49 UTC (permalink / raw)
To: mahesh; +Cc: j.vosburgh, andy, vfalico, nikolay, edumazet, netdev, maheshb
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Tue, 11 Apr 2017 22:36:00 -0700
> From: Mahesh Bandewar <maheshb@google.com>
>
> When link transitions from LINK_FAIL to LINK_UP, the commit phase is
> not called. This leads to an erroneous state causing slave-link state to
> get stuck in "going down" state while its speed and duplex are perfectly
> fine. This issue is a side-effect of splitting link-set into propose and
> commit phases introduced by de77ecd4ef02 ("bonding: improve link-status
> update in mii-monitoring")
>
> This patch fixes these issues by calling commit phase whenever link
> state change is proposed.
>
> Fixes: de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-13 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-12 5:36 [PATCH next] bonding: handle link transition from FAIL to UP correctly Mahesh Bandewar
2017-04-13 17:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).