Re: [PATCH net-next 0/8] net/ncsi: Add debugging functionality

[Gavin Shan <gwshan@linux.vnet.ibm.com>]

On Thu, Apr 13, 2017 at 12:46:32PM +1000, Gavin Shan wrote:
>This series supports NCSI debugging infrastructure by adding several
>procfs files. It was inspired by the reported issues: No available
>package and channel are probed successfully. Obviously, we don't
>have a debugging infrastructure for NCSI stack yet.
>
>The first 3 patches, fixing some issues, aren't relevant to the
>subject. I included them because I expect they can be merged beofre
>the code for debugging infrastructure. PATCH[4,5,6/8] adds procfs
>directories and files to support the debugging infrastructure for
>several purposes: presenting the NCSI topology; statistics on sent
>and received NCSI packets; generate NCSI command packet manually.
>PATCH[7,8/8] fixes two issues found from the debugging functionality.
>

An updated series (v2) was posted, to replace procfs with debugfs
according to Joe's comment on PATCH[5/8]. Please review v2 if possible.

Cheers,
Gavin

>Gavin Shan (8):
>  net/ncsi: Disable HWA mode when no channels are found
>  net/ncsi: Properly track channel monitor timer state
>  net/ncsi: Enforce failover on link monitor timeout
>  net/ncsi: Add debugging infrastructurre
>  net/ncsi: Dump NCSI packet statistics
>  net/ncsi: Support NCSI packet generation
>  net/ncsi: No error report on DP response to non-existing package
>  net/ncsi: Fix length of GVI response packet
>
> net/ncsi/Kconfig       |   9 +
> net/ncsi/Makefile      |   1 +
> net/ncsi/internal.h    |  68 ++++
> net/ncsi/ncsi-aen.c    |  15 +-
> net/ncsi/ncsi-cmd.c    |  23 +-
> net/ncsi/ncsi-debug.c  | 961 +++++++++++++++++++++++++++++++++++++++++++++++++
> net/ncsi/ncsi-manage.c |  63 +++-
> net/ncsi/ncsi-rsp.c    |  37 +-
> 8 files changed, 1165 insertions(+), 12 deletions(-)
> create mode 100644 net/ncsi/ncsi-debug.c
>
>-- 
>2.7.4
>