* [PATCH -next] net: phy: test the right variable in phy_write_mmd()
@ 2017-04-14 19:10 Dan Carpenter
2017-04-14 19:14 ` Andrew Lunn
2017-04-17 19:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-04-14 19:10 UTC (permalink / raw)
To: Andrew Lunn, Russell King; +Cc: Florian Fainelli, netdev, kernel-janitors
This is a copy and paste buglet. We meant to test for ->write_mmd but
we test for ->read_mmd.
Fixes: 1ee6b9bc6206 ("net: phy: make phy_(read|write)_mmd() generic MMD accessors")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c
index 357a4d0d7641..6739b738bbaf 100644
--- a/drivers/net/phy/phy-core.c
+++ b/drivers/net/phy/phy-core.c
@@ -76,7 +76,7 @@ int phy_write_mmd(struct phy_device *phydev, int devad, u32 regnum, u16 val)
if (regnum > (u16)~0 || devad > 32)
return -EINVAL;
- if (phydev->drv->read_mmd) {
+ if (phydev->drv->write_mmd) {
ret = phydev->drv->write_mmd(phydev, devad, regnum, val);
} else if (phydev->is_c45) {
u32 addr = MII_ADDR_C45 | (devad << 16) | (regnum & 0xffff);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: phy: test the right variable in phy_write_mmd()
2017-04-14 19:10 [PATCH -next] net: phy: test the right variable in phy_write_mmd() Dan Carpenter
@ 2017-04-14 19:14 ` Andrew Lunn
2017-04-17 19:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-04-14 19:14 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Russell King, Florian Fainelli, netdev, kernel-janitors
On Fri, Apr 14, 2017 at 10:10:41PM +0300, Dan Carpenter wrote:
> This is a copy and paste buglet. We meant to test for ->write_mmd but
> we test for ->read_mmd.
>
> Fixes: 1ee6b9bc6206 ("net: phy: make phy_(read|write)_mmd() generic MMD accessors")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: phy: test the right variable in phy_write_mmd()
2017-04-14 19:10 [PATCH -next] net: phy: test the right variable in phy_write_mmd() Dan Carpenter
2017-04-14 19:14 ` Andrew Lunn
@ 2017-04-17 19:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-04-17 19:11 UTC (permalink / raw)
To: dan.carpenter; +Cc: andrew, rmk+kernel, f.fainelli, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 14 Apr 2017 22:10:41 +0300
> This is a copy and paste buglet. We meant to test for ->write_mmd but
> we test for ->read_mmd.
>
> Fixes: 1ee6b9bc6206 ("net: phy: make phy_(read|write)_mmd() generic MMD accessors")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-17 19:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-14 19:10 [PATCH -next] net: phy: test the right variable in phy_write_mmd() Dan Carpenter
2017-04-14 19:14 ` Andrew Lunn
2017-04-17 19:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).