From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
arkadis@mellanox.com, idosch@mellanox.com, mlxsw@mellanox.com,
jhs@mojatatu.com, ivecera@redhat.com, roopa@cumulusnetworks.com,
f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com,
john.fastabend@gmail.com, andrew@lunn.ch,
simon.horman@netronome.com
Subject: Re: [patch iproute2/net-next repost] devlink: Add support for pipeline debug (dpipe)
Date: Sat, 15 Apr 2017 09:57:05 -0400 (EDT) [thread overview]
Message-ID: <20170415.095705.1787032921503797059.davem@davemloft.net> (raw)
In-Reply-To: <20170415085903.GA2142@nanopsycho.orion>
From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 15 Apr 2017 10:59:03 +0200
> Sat, Apr 15, 2017 at 01:01:38AM CEST, stephen@networkplumber.org wrote:
>>On Thu, 13 Apr 2017 11:30:27 +0200
>>Jiri Pirko <jiri@resnulli.us> wrote:
>>
>>> We actually took this code from teamdctl (at least it was an influence).
>>> Devlink style is so much different in every aspect from the rest of the
>>> iproute2 suite. And I did it on purpose, because it is much nicer and
>>> easier to read. I would like to continue on this and don't do things in
>>> the was the existing tools do. I don't see any problem with that.
>>
>>No. That is road to ruin. Every package is free to use what ever style
>>it wants. But don't crossover please.
>
> So we are stuck with some ugly way just because some other util does it?
> Well, in devlink I wrote lot of things differently, nicer. For example
> cmdline parsing. Why is it a "road to ruin"?
I agree with Jiri, if he wants to stylize devlink a certain way that
makes sense for devlink information, that is perfectly fine and does
not impact the way the rest of iproute2's output appears to the user
at all.
next prev parent reply other threads:[~2017-04-15 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 15:24 [patch net-next v2 0/8] Add support for pipeline debug (dpipe) Jiri Pirko
2017-03-28 15:24 ` [patch net-next v2 1/8] devlink: Support " Jiri Pirko
2017-03-28 15:24 ` [patch net-next v2 2/8] mlxsw: reg: Add counter fields to RITR register Jiri Pirko
2017-03-28 15:24 ` [patch net-next v2 3/8] mlxsw: spectrum: Add placeholder for dpipe Jiri Pirko
2017-03-28 15:24 ` [patch net-next v2 4/8] mlxsw: spectrum: Add definition for egress rif table Jiri Pirko
2017-03-28 15:24 ` [patch net-next v2 5/8] mlxsw: reg: Add Router Interface Counter Register Jiri Pirko
2017-03-28 15:24 ` [patch net-next v2 6/8] mlxsw: spectrum: Support for counters on router interfaces Jiri Pirko
2017-03-28 15:24 ` [patch net-next v2 7/8] mlxsw: spectrum_router: Add rif helper functions Jiri Pirko
2017-03-28 15:24 ` [patch net-next v2 8/8] mlxsw: spectrum: Add Support for erif table entries access Jiri Pirko
2017-03-28 15:26 ` [patch iproute2/net-next repost] devlink: Add support for pipeline debug (dpipe) Jiri Pirko
2017-04-12 23:45 ` Stephen Hemminger
2017-04-13 9:30 ` Jiri Pirko
2017-04-14 23:01 ` Stephen Hemminger
2017-04-15 8:59 ` Jiri Pirko
2017-04-15 13:57 ` David Miller [this message]
2017-03-28 16:41 ` [patch net-next v2 0/8] " Ivan Vecera
2017-03-29 0:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170415.095705.1787032921503797059.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=arkadis@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=ivecera@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).