From: David Miller <davem@davemloft.net>
To: clg@kaod.org
Cc: gwshan@linux.vnet.ibm.com, joel@jms.id.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ncsi: fix checksum validation in response packet
Date: Mon, 17 Apr 2017 13:36:19 -0400 (EDT) [thread overview]
Message-ID: <20170417.133619.1515025171498720534.davem@davemloft.net> (raw)
In-Reply-To: <1492160197-13816-1-git-send-email-clg@kaod.org>
From: Cédric Le Goater <clg@kaod.org>
Date: Fri, 14 Apr 2017 10:56:37 +0200
> htonl was used instead of ntohl. Surely a typo.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
I don't think so, "checksum" is of type "u32" thus is in host byte
order. Therefore "htonl()" is correct.
next prev parent reply other threads:[~2017-04-17 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 8:56 [PATCH] net/ncsi: fix checksum validation in response packet Cédric Le Goater
2017-04-17 17:36 ` David Miller [this message]
2017-04-18 0:06 ` Gavin Shan
2017-04-18 6:16 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417.133619.1515025171498720534.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=clg@kaod.org \
--cc=gwshan@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).