From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: jhs@mojatatu.com, eric.dumazet@gmail.com, netdev@vger.kernel.org,
xiyou.wangcong@gmail.com
Subject: Re: Case for reusing netlink PADs WAS(Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch
Date: Tue, 18 Apr 2017 11:29:35 -0400 (EDT) [thread overview]
Message-ID: <20170418.112935.686195434402345158.davem@davemloft.net> (raw)
In-Reply-To: <20170418131656.GG1871@nanopsycho.orion>
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 18 Apr 2017 15:16:56 +0200
> It's ugly. Plus user may pass garbage in pads from current apps.
%100 agreed.
> Why you don't just use new attributes? I don't get it. I still
> don't understand why people feel need to do struct style message
> passing in TLV-designed Netlink interface...
Also agreed, I don't see why it's such a big deal.
Once we define a structure, let's set it in stone and don't try to
modify it's layout or meaning. It is the only safe approach.
We made netlink have attributes exactly for this reason.
next prev parent reply other threads:[~2017-04-18 15:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 12:34 [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Jamal Hadi Salim
2017-04-17 8:19 ` Jiri Pirko
2017-04-17 11:01 ` Jamal Hadi Salim
2017-04-17 13:10 ` Eric Dumazet
2017-04-17 14:02 ` Jamal Hadi Salim
2017-04-17 14:58 ` Eric Dumazet
2017-04-17 16:40 ` Jamal Hadi Salim
2017-04-17 15:31 ` Jiri Pirko
2017-04-17 16:46 ` Jamal Hadi Salim
2017-04-17 17:04 ` Jiri Pirko
2017-04-17 17:08 ` Eric Dumazet
2017-04-17 17:51 ` Roman Mashak
2017-04-18 12:48 ` Case for reusing netlink PADs WAS(Re: " Jamal Hadi Salim
2017-04-18 13:16 ` Jiri Pirko
2017-04-18 15:29 ` David Miller [this message]
2017-04-18 14:19 ` Eric Dumazet
2017-04-18 15:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418.112935.686195434402345158.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).