netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com
Subject: Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo
Date: Tue, 18 Apr 2017 13:12:53 -0400 (EDT)	[thread overview]
Message-ID: <20170418.131253.2065320027211688167.davem@davemloft.net> (raw)
In-Reply-To: <20170418140653.8839-1-colin.king@canonical.com>

From: Colin King <colin.king@canonical.com>
Date: Tue, 18 Apr 2017 15:06:53 +0100

Trimming the CC: list down to something that actually makes
sense.

> From: Colin Ian King <colin.king@canonical.com>
> 
> The check for xo being null is incorrect, currently it is checking
> for non-null, it should be checking for null.
> 
> Detected with CoverityScan, CID#1429349 ("Dereference after null check")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

At a minimum you should work to check that you are CC:'ing the person
who added the code you are fixing.  You can use "git blame" for this.

Also, Steffen, you need to add the new IPSEC offload files to the
MAINTAINERS entry for iPSEC.

Thank you.

  reply	other threads:[~2017-04-18 17:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 14:06 [PATCH][net-next] esp6: fix incorrect null pointer check on xo Colin King
2017-04-18 17:12 ` David Miller [this message]
2017-04-19  5:20   ` Steffen Klassert
2017-04-18 20:11 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418.131253.2065320027211688167.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=colin.king@canonical.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).