netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org, netdev@vger.kernel.org,
	ast@kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH net-next 1/2] sparc: Split BPF JIT into 32-bit and 64-bit.
Date: Tue, 18 Apr 2017 21:31:57 +0200	[thread overview]
Message-ID: <20170418193157.GA29862@ravnborg.org> (raw)
In-Reply-To: <20170418.145806.845080704857445577.davem@davemloft.net>

On Tue, Apr 18, 2017 at 02:58:06PM -0400, David Miller wrote:
> 
> This is in preparation for adding the 64-bit eBPF JIT.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>  arch/sparc/net/Makefile          |   2 +-
>  arch/sparc/net/bpf_jit.h         |  68 ----
>  arch/sparc/net/bpf_jit_32.h      |  68 ++++
>  arch/sparc/net/bpf_jit_asm.S     | 208 ----------
>  arch/sparc/net/bpf_jit_asm_32.S  | 208 ++++++++++
>  arch/sparc/net/bpf_jit_asm_64.S  |   1 +
>  arch/sparc/net/bpf_jit_comp.c    | 815 ---------------------------------------
>  arch/sparc/net/bpf_jit_comp_32.c | 815 +++++++++++++++++++++++++++++++++++++++
>  arch/sparc/net/bpf_jit_comp_64.c |   1 +
>  9 files changed, 1094 insertions(+), 1092 deletions(-)
>  delete mode 100644 arch/sparc/net/bpf_jit.h
>  create mode 100644 arch/sparc/net/bpf_jit_32.h
>  delete mode 100644 arch/sparc/net/bpf_jit_asm.S
>  create mode 100644 arch/sparc/net/bpf_jit_asm_32.S
>  create mode 100644 arch/sparc/net/bpf_jit_asm_64.S
>  delete mode 100644 arch/sparc/net/bpf_jit_comp.c
>  create mode 100644 arch/sparc/net/bpf_jit_comp_32.c
>  create mode 100644 arch/sparc/net/bpf_jit_comp_64.c

Adding options "-M -C" to git format-patch would have helped readability
of this patch.
As it is now we cannot see what changes were made to the varoious files
when they were renamed.

(I trust you have made no irrelevant but wanted to mention it anyway)

	Sam

  reply	other threads:[~2017-04-18 19:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 18:58 [PATCH net-next 1/2] sparc: Split BPF JIT into 32-bit and 64-bit David Miller
2017-04-18 19:31 ` Sam Ravnborg [this message]
2017-04-18 19:35   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418193157.GA29862@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).