From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] dp83640: don't recieve time stamps twice Date: Wed, 19 Apr 2017 13:53:26 +0300 Message-ID: <20170419105326.45khz5ayre75d5i2@mwanda> References: <20170418191426.GA17838@mwanda> <1492593414.3108.1.camel@spectralink.com> <20170419103135.GA1670@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: =?iso-8859-1?B?U/hyZW5zZW4s?= Stefan , "netdev@vger.kernel.org" , "f.fainelli@gmail.com" , "andrew@lunn.ch" , "kernel-janitors@vger.kernel.org" To: Richard Cochran Return-path: Content-Disposition: inline In-Reply-To: <20170419103135.GA1670@localhost.localdomain> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Apr 19, 2017 at 12:31:35PM +0200, Richard Cochran wrote: > On Wed, Apr 19, 2017 at 09:16:56AM +0000, Sørensen, Stefan wrote: > > You are correct that these lines was added accidentally. > > Can we please fix this in another way? There is no need to hold the > spin lock during the callback into the networking stack. Instead, how > about the following diff, which also fixes the other call site... > I'm fine with this. I hated my changelog, as well because it sounds like guess work. Could you send it with a: Reported-by: Dan Carpenter regards, dan carpenter