* [PATCH net-next] bpf: remove reference to sock_filter_ext from kerneldoc comment
@ 2017-04-18 9:27 Tobias Klauser
2017-04-18 9:34 ` Daniel Borkmann
2017-04-20 19:27 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Tobias Klauser @ 2017-04-18 9:27 UTC (permalink / raw)
To: netdev; +Cc: Daniel Borkmann, Alexei Starovoitov
struct sock_filter_ext didn't make it into the tree and is now called
struct bpf_insn. Reword the kerneldoc comment for bpf_convert_filter()
accordingly.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
net/core/filter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index ce2a19da8aa4..42a7f08b609f 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -354,7 +354,8 @@ static bool convert_bpf_extensions(struct sock_filter *fp,
* @new_prog: buffer where converted program will be stored
* @new_len: pointer to store length of converted program
*
- * Remap 'sock_filter' style BPF instruction set to 'sock_filter_ext' style.
+ * Remap 'sock_filter' style classic BPF (cBPF) instruction set to 'bpf_insn'
+ * style extended BPF (eBPF).
* Conversion workflow:
*
* 1) First pass for calculating the new program length:
--
2.12.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bpf: remove reference to sock_filter_ext from kerneldoc comment
2017-04-18 9:27 [PATCH net-next] bpf: remove reference to sock_filter_ext from kerneldoc comment Tobias Klauser
@ 2017-04-18 9:34 ` Daniel Borkmann
2017-04-18 17:50 ` Alexei Starovoitov
2017-04-20 19:27 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2017-04-18 9:34 UTC (permalink / raw)
To: Tobias Klauser, netdev; +Cc: Alexei Starovoitov
On 04/18/2017 11:27 AM, Tobias Klauser wrote:
> struct sock_filter_ext didn't make it into the tree and is now called
> struct bpf_insn. Reword the kerneldoc comment for bpf_convert_filter()
> accordingly.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Good point, thanks!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bpf: remove reference to sock_filter_ext from kerneldoc comment
2017-04-18 9:34 ` Daniel Borkmann
@ 2017-04-18 17:50 ` Alexei Starovoitov
0 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2017-04-18 17:50 UTC (permalink / raw)
To: Daniel Borkmann, Tobias Klauser, netdev
On 4/18/17 2:34 AM, Daniel Borkmann wrote:
> On 04/18/2017 11:27 AM, Tobias Klauser wrote:
>> struct sock_filter_ext didn't make it into the tree and is now called
>> struct bpf_insn. Reword the kerneldoc comment for bpf_convert_filter()
>> accordingly.
>>
>> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>
> Good point, thanks!
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
good ol' days :)
let it rip.
Acked-by: Alexei Starovoitov <ast@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bpf: remove reference to sock_filter_ext from kerneldoc comment
2017-04-18 9:27 [PATCH net-next] bpf: remove reference to sock_filter_ext from kerneldoc comment Tobias Klauser
2017-04-18 9:34 ` Daniel Borkmann
@ 2017-04-20 19:27 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2017-04-20 19:27 UTC (permalink / raw)
To: tklauser; +Cc: netdev, daniel, ast
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 18 Apr 2017 11:27:00 +0200
> struct sock_filter_ext didn't make it into the tree and is now called
> struct bpf_insn. Reword the kerneldoc comment for bpf_convert_filter()
> accordingly.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-20 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-18 9:27 [PATCH net-next] bpf: remove reference to sock_filter_ext from kerneldoc comment Tobias Klauser
2017-04-18 9:34 ` Daniel Borkmann
2017-04-18 17:50 ` Alexei Starovoitov
2017-04-20 19:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).