From: Steffen Klassert <steffen.klassert@secunet.com>
To: <ilant@mellanox.com>
Cc: <netdev@vger.kernel.org>, Boris Pismenny <borisp@mellanox.com>,
"Yevgeny Kliteynik" <kliteyn@mellanox.com>,
Yossi Kuperman <yossiku@mellanox.com>
Subject: Re: [PATCH ipsec-next] esp4/6: Fix GSO path for non-GSO SW-crypto packets
Date: Thu, 20 Apr 2017 07:16:46 +0200 [thread overview]
Message-ID: <20170420051645.GA3976@secunet.com> (raw)
In-Reply-To: <20170419054101.16738-1-ilant@mellanox.com>
On Wed, Apr 19, 2017 at 08:41:01AM +0300, ilant@mellanox.com wrote:
> From: Ilan Tayari <ilant@mellanox.com>
>
> If esp*_offload module is loaded, outbound packets take the
> GSO code path, being encapsulated at layer 3, but encrypted
> in layer 2. validate_xmit_xfrm calls esp*_xmit for that.
>
> esp*_xmit was wrongfully detecting these packets as going
> through hardware crypto offload, while in fact they should
> be encrypted in software, causing plaintext leakage to
> the network, and also dropping at the receiver side.
>
> Perform the encryption in esp*_xmit, if the SA doesn't have
> a hardware offload_handle.
>
> Also, align esp6 code to esp4 logic.
>
> Fixes: fca11ebde3f0 ("esp4: Reorganize esp_output")
> Fixes: 383d0350f2cc ("esp6: Reorganize esp_output")
> Signed-off-by: Ilan Tayari <ilant@mellanox.com>
Applied to ipsec-next, thanks Ilan!
prev parent reply other threads:[~2017-04-20 5:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 5:41 [PATCH ipsec-next] esp4/6: Fix GSO path for non-GSO SW-crypto packets ilant
2017-04-20 5:16 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420051645.GA3976@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=borisp@mellanox.com \
--cc=ilant@mellanox.com \
--cc=kliteyn@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yossiku@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).