From: Jiri Pirko <jiri@resnulli.us>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: davem@davemloft.net, xiyou.wangcong@gmail.com,
eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch
Date: Thu, 20 Apr 2017 17:13:53 +0200 [thread overview]
Message-ID: <20170420151353.GB19004@nanopsycho.orion> (raw)
In-Reply-To: <7e9dbb08-fb80-aee6-a0d0-dce56cbfd7c3@mojatatu.com>
Thu, Apr 20, 2017 at 05:08:20PM CEST, jhs@mojatatu.com wrote:
>On 17-04-20 10:33 AM, Jiri Pirko wrote:
>> Thu, Apr 20, 2017 at 04:25:11PM CEST, jhs@mojatatu.com wrote:
>
>> > > TCAA stands for "traffic control action action". I don't get it :(
>> >
>> > TC Action Attributes == TCAA.
>> >
>> > > Prefix still sounds wrong to me, sorry :/
>> > > Should be:
>> > > TCA_SOMETHING_*
>> > >
>> >
>> > TCA_ATTR_XXX ?
>>
>> Of course it is an attribute. No need to have "attr" in the name. No
>> other enum has it. Does not make sense.
>>
>> The name should contain the group name. What group this enum defines?
>>
>
>It defines tc root level Action attributes.
>Would TCRLAA_XXX be more exciting? ;->
How about TCA_ROOT_XXX
>
>cheers,
>jamal
>
next prev parent reply other threads:[~2017-04-20 15:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 13:06 [PATCH net-next v5 0/2] net sched actions: improve action dump performance Jamal Hadi Salim
2017-04-20 13:06 ` [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Jamal Hadi Salim
2017-04-20 13:59 ` Jiri Pirko
2017-04-20 14:18 ` Jamal Hadi Salim
2017-04-20 14:24 ` Jiri Pirko
2017-04-24 9:14 ` Simon Horman
2017-04-24 12:49 ` Jamal Hadi Salim
2017-04-24 14:20 ` Pablo Neira Ayuso
2017-04-24 14:42 ` Jamal Hadi Salim
2017-04-24 20:30 ` David Miller
2017-04-24 22:18 ` Jamal Hadi Salim
2017-04-24 22:24 ` David Miller
2017-04-24 22:58 ` Jamal Hadi Salim
2017-04-20 14:25 ` Jamal Hadi Salim
2017-04-20 14:33 ` Jiri Pirko
2017-04-20 15:08 ` Jamal Hadi Salim
2017-04-20 15:13 ` Jiri Pirko [this message]
2017-04-20 16:09 ` Eric Dumazet
2017-04-20 17:39 ` Jamal Hadi Salim
2017-04-20 13:06 ` [PATCH net-next v5 2/2] net sched actions: add time filter for action dumping Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420151353.GB19004@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).