From: David Miller <davem@davemloft.net>
To: ilant@mellanox.com
Cc: netdev@vger.kernel.org, alexander.h.duyck@intel.com,
eric.dumazet@gmail.com, steffen.klassert@secunet.com,
borisp@mellanox.com, ilyal@mellanox.com
Subject: Re: [PATCH net] gso: Validate assumption of frag_list segementation
Date: Fri, 21 Apr 2017 13:30:52 -0400 (EDT) [thread overview]
Message-ID: <20170421.133052.1192709001555652314.davem@davemloft.net> (raw)
In-Reply-To: <20170419182607.2342-1-ilant@mellanox.com>
From: <ilant@mellanox.com>
Date: Wed, 19 Apr 2017 21:26:07 +0300
> From: Ilan Tayari <ilant@mellanox.com>
>
> Commit 07b26c9454a2 ("gso: Support partial splitting at the frag_list
> pointer") assumes that all SKBs in a frag_list (except maybe the last
> one) contain the same amount of GSO payload.
>
> This assumption is not always correct, resulting in the following
> warning message in the log:
> skb_segment: too many frags
>
> For example, mlx5 driver in Striding RQ mode creates some RX SKBs with
> one frag, and some with 2 frags.
> After GRO, the frag_list SKBs end up having different amounts of payload.
> If this frag_list SKB is then forwarded, the aforementioned assumption
> is violated.
>
> Validate the assumption, and fall back to software GSO if it not true.
>
> Change-Id: Ia03983f4a47b6534dd987d7a2aad96d54d46d212
> Fixes: 07b26c9454a2 ("gso: Support partial splitting at the frag_list pointer")
> Signed-off-by: Ilan Tayari <ilant@mellanox.com>
> Signed-off-by: Ilya Lesokhin <ilyal@mellanox.com>
Applied.
prev parent reply other threads:[~2017-04-21 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 18:26 [PATCH net] gso: Validate assumption of frag_list segementation ilant
2017-04-21 17:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421.133052.1192709001555652314.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=borisp@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=ilant@mellanox.com \
--cc=ilyal@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).