From: David Miller <davem@davemloft.net>
To: mahesh@bandewar.net
Cc: j.vosburgh@gmail.com, andy@greyhouse.net, vfalico@gmail.com,
nikolay@redhat.com, edumazet@google.com, joe@ovn.org,
netdev@vger.kernel.org, maheshb@google.com
Subject: Re: [PATCHv2 next] bonding: fix wq initialization for links created via netlink
Date: Fri, 21 Apr 2017 15:29:13 -0400 (EDT) [thread overview]
Message-ID: <20170421.152913.1790106808332321956.davem@davemloft.net> (raw)
In-Reply-To: <20170420194924.20829-1-mahesh@bandewar.net>
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Thu, 20 Apr 2017 12:49:24 -0700
> From: Mahesh Bandewar <maheshb@google.com>
>
> Earlier patch 4493b81bea ("bonding: initialize work-queues during
> creation of bond") moved the work-queue initialization from bond_open()
> to bond_create(). However this caused the link those are created using
> netlink 'create bond option' (ip link add bondX type bond); create the
> new trunk without initializing work-queues. Prior to the above mentioned
> change, ndo_open was in both paths and things worked correctly. The
> consequence is visible in the report shared by Joe Stringer -
>
> I've noticed that this patch breaks bonding within namespaces if
> you're not careful to perform device cleanup correctly.
>
> Here's my repro script, you can run on any net-next with this patch
> and you'll start seeing some weird behaviour:
...
> Fixes: 4493b81bea ("bonding: initialize work-queues during creation of bond")
> Reported-by: Joe Stringer <joe@ovn.org>
> Tested-by: Joe Stringer <joe@ovn.org>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied, thanks.
prev parent reply other threads:[~2017-04-21 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 19:49 [PATCHv2 next] bonding: fix wq initialization for links created via netlink Mahesh Bandewar
2017-04-20 21:46 ` Andy Gospodarek
2017-04-21 19:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421.152913.1790106808332321956.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=joe@ovn.org \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox